From: Jagadeesh Kona <quic_jkona@quicinc.com>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Bjorn Andersson <andersson@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
"Stephen Boyd" <sboyd@kernel.org>,
Stanimir Varbanov <stanimir.k.varbanov@gmail.com>,
Vikash Garodia <quic_vgarodia@quicinc.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Kevin Hilman <khilman@kernel.org>, Pavel Machek <pavel@ucw.cz>,
Len Brown <len.brown@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
"Andy Gross" <agross@kernel.org>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Abel Vesa <abel.vesa@linaro.org>
Cc: <linux-arm-msm@vger.kernel.org>, <linux-clk@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-media@vger.kernel.org>,
<linux-pm@vger.kernel.org>, Taniya Das <quic_tdas@quicinc.com>,
"Satya Priya Kakitapalli" <quic_skakitap@quicinc.com>,
Imran Shaik <quic_imrashai@quicinc.com>,
Ajit Pandey <quic_ajipan@quicinc.com>
Subject: Re: [PATCH V5 RESEND 5/5] venus: pm_helpers: Use dev_pm_genpd_set_hwmode to switch GDSC mode on V6
Date: Sun, 14 Apr 2024 20:22:17 +0530 [thread overview]
Message-ID: <b96ef82c-4033-43e0-9c1e-347ffb500751@quicinc.com> (raw)
In-Reply-To: <5c78ad52-524b-4ad7-b149-0e7252abc2ee@linaro.org>
On 4/14/2024 6:09 PM, Bryan O'Donoghue wrote:
> On 13/04/2024 16:20, Jagadeesh Kona wrote:
>> The Venus driver requires vcodec GDSC to be ON in SW mode for clock
>> operations and move it back to HW mode to gain power benefits. Earlier,
>> as there is no interface to switch the GDSC mode from GenPD framework,
>> the GDSC is moved to HW control mode as part of GDSC enable callback and
>> venus driver is writing to its POWER_CONTROL register to keep the GDSC ON
>> from SW whereever required. But the POWER_CONTROL register addresses
>> are not constant and can vary across the variants.
>>
>> Also as per the HW recommendation, the GDSC mode switching needs to be
>> controlled from respective GDSC register and this is a uniform approach
>> across all the targets. Hence use dev_pm_genpd_set_hwmode() API which
>> controls GDSC mode switching using its respective GDSC register.
>>
>> In venus V6 variants, the vcodec gdsc gets enabled in SW mode by default
>> with new HW_CTRL_TRIGGER flag and there is no need to switch it to SW
>> mode again after enable, hence add check to avoid switching gdsc to SW
>> mode
>> again after gdsc enable. Similarly add check to avoid switching GDSC
>> to HW
>> mode before disabling the GDSC, so GDSC gets enabled in SW mode in the
>> next
>> enable.
>>
>> Signed-off-by: Jagadeesh Kona <quic_jkona@quicinc.com>
>> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
>> ---
>
> When I tested this out on sm8250 a few months ago it was broken.
>
> I don't quite see in your commit logs, how the breakage was addressed.
>
> Can you provide some details ?
>
Thanks Bryan for your review!
In earlier series, venus driver is switching the vcodec GDSC to HW
control mode before disabling the GDSC by invoking
vcodec_control_v4(..., false) in poweroff_coreid(). Due to this, the
subsequent GDSC enable from venus driver is failing while polling for
GDSC power ON status, since GDSC is under HW control mode and HW can
keep the GDSC in disabled state.
Now a check is added in poweroff_coreid() to avoid switching the GDSC to
HW control mode before disabling the GDSC for Venus V6 variants that use
this new API. Hence during the next GDSC enable, GDSC will be in SW mode
and GDSC will powerup properly.
Thanks,
Jagadeesh
> ---
> bod
>
next prev parent reply other threads:[~2024-04-14 14:53 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-13 15:20 [PATCH V5 RESEND 0/5] PM: domains: Add control for switching back and forth to HW control Jagadeesh Kona
2024-04-13 15:20 ` [PATCH V5 RESEND 1/5] PM: domains: Allow devices attached to genpd to be managed by HW Jagadeesh Kona
2024-04-13 15:20 ` [PATCH V5 RESEND 2/5] PM: domains: Add the domain HW-managed mode to the summary Jagadeesh Kona
2024-04-13 15:20 ` [PATCH V5 RESEND 3/5] clk: qcom: gdsc: Add set and get hwmode callbacks to switch GDSC mode Jagadeesh Kona
2024-04-23 23:48 ` Bryan O'Donoghue
2024-04-24 9:47 ` Jagadeesh Kona
2024-04-24 9:55 ` Bryan O'Donoghue
2024-04-24 10:27 ` Jagadeesh Kona
2024-04-24 12:22 ` Konrad Dybcio
2024-04-24 12:25 ` Konrad Dybcio
2024-04-13 15:20 ` [PATCH V5 RESEND 4/5] clk: qcom: Use HW_CTRL_TRIGGER flag to switch video GDSC to HW mode Jagadeesh Kona
2024-04-22 22:54 ` Konrad Dybcio
2024-04-24 9:48 ` Jagadeesh Kona
2024-04-13 15:20 ` [PATCH V5 RESEND 5/5] venus: pm_helpers: Use dev_pm_genpd_set_hwmode to switch GDSC mode on V6 Jagadeesh Kona
2024-04-14 12:39 ` Bryan O'Donoghue
2024-04-14 14:52 ` Jagadeesh Kona [this message]
2024-04-24 0:16 ` Bryan O'Donoghue
2024-04-24 9:45 ` Jagadeesh Kona
2024-04-24 9:50 ` Bryan O'Donoghue
2024-04-30 20:01 ` Konrad Dybcio
2024-05-01 9:14 ` Bryan O'Donoghue
2024-05-10 13:01 ` Bryan O'Donoghue
2024-05-31 11:56 ` Jagadeesh Kona
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b96ef82c-4033-43e0-9c1e-347ffb500751@quicinc.com \
--to=quic_jkona@quicinc.com \
--cc=abel.vesa@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=khilman@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=len.brown@intel.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=mturquette@baylibre.com \
--cc=pavel@ucw.cz \
--cc=quic_ajipan@quicinc.com \
--cc=quic_imrashai@quicinc.com \
--cc=quic_skakitap@quicinc.com \
--cc=quic_tdas@quicinc.com \
--cc=quic_vgarodia@quicinc.com \
--cc=rafael@kernel.org \
--cc=sboyd@kernel.org \
--cc=stanimir.k.varbanov@gmail.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).