From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: "Ondřej Jirman" <megi@xff.cz>,
git@luigi311.com, linux-media@vger.kernel.org,
dave.stevenson@raspberrypi.com, jacopo.mondi@ideasonboard.com,
mchehab@kernel.org, robh@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com,
devicetree@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, pavel@ucw.cz,
phone-devel@vger.kernel.org,
"Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>
Subject: Re: [PATCH v5 21/25] dt-bindings: media: imx258: Add binding for powerdown-gpio
Date: Mon, 20 May 2024 13:19:40 +0000 [thread overview]
Message-ID: <ZktN7EcXiqupI9Qd@kekkonen.localdomain> (raw)
In-Reply-To: <q5nbk3qcxsjsqp4mdyx5nlrn4oie6oynunwodm7r2nwtywc2ey@kxsgcatwt5b2>
Hi Ondřej,
On Mon, May 20, 2024 at 02:55:26PM +0200, Ondřej Jirman wrote:
> On Fri, May 17, 2024 at 08:31:35AM GMT, Sakari Ailus wrote:
> > Hi Luis,
> >
> > On Wed, May 01, 2024 at 09:24:38AM -0600, git@luigi311.com wrote:
> > > From: Ondrej Jirman <megi@xff.cz>
> > >
> > > Add powerdown-gpio binding as it is required for some boards.
> >
> > I thought the conclusion was that this wasn't a property of the sensor? If
> > it needs to be controlled, then this should take place somewhere else than
> > in the sensor driver.
>
> It's a property of the sensor modules. It's just optional on
> some, eg. (pin 8):
>
> https://assets-global.website-files.com/63b65bd4974577341e1fe194/654290d4d0fb173e87f754ed_IMX_258_FF_drawing.png
>
> Where else should it be so that the module is described properly in the
> DT and the powerdown signal can be used as part of powerup/down sequence
> of the sensor?
That's an interesting case. The document does suggest the PWDN pin isn't
connected though.
Is this pin used for something? If so, what is it? The sensor doesn't have
it and generally the module in this respect just contains wiring.
Someone earlier suggested this could have been related to the VCM.
--
Regards,
Sakari Ailus
next prev parent reply other threads:[~2024-05-20 13:19 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-01 15:24 [PATCH v5 00/25] imx258 improvement series git
2024-05-01 15:24 ` [PATCH v5 01/25] media: i2c: imx258: Remove unused defines git
2024-05-01 15:24 ` [PATCH v5 02/25] media: i2c: imx258: Make image geometry meet sensor requirements git
2024-05-01 15:24 ` [PATCH v5 03/25] media: i2c: imx258: Disable digital cropping on binned modes git
2024-05-01 15:24 ` [PATCH v5 04/25] media: i2c: imx258: Remove redundant I2C writes git
2024-05-01 15:24 ` [PATCH v5 05/25] media: i2c: imx258: Add regulator control git
2024-05-01 15:24 ` [PATCH v5 06/25] media: i2c: imx258: Make V4L2_CID_VBLANK configurable git
2024-05-01 15:24 ` [PATCH v5 07/25] media: i2c: imx258: Split out common registers from the mode based ones git
2024-05-01 15:24 ` [PATCH v5 08/25] media: i2c: imx258: Add support for 24MHz clock git
2024-05-01 15:24 ` [PATCH v5 09/25] media: i2c: imx258: Add support for running on 2 CSI data lanes git
2024-05-01 15:24 ` [PATCH v5 10/25] media: i2c: imx258: Follow normal V4L2 behaviours for clipping exposure git
2024-05-01 15:24 ` [PATCH v5 11/25] media: i2c: imx258: Add get_selection for pixel array information git
2024-05-01 15:24 ` [PATCH v5 12/25] media: i2c: imx258: Allow configuration of clock lane behaviour git
2024-05-01 15:24 ` [PATCH v5 13/25] media: i2c: imx258: Correct max FRM_LENGTH_LINES value git
2024-05-01 15:24 ` [PATCH v5 14/25] media: i2c: imx258: Issue reset before starting streaming git
2024-05-01 15:24 ` [PATCH v5 15/25] media: i2c: imx258: Set pixel_rate range to the same as the value git
2024-05-01 15:24 ` [PATCH v5 16/25] media: i2c: imx258: Support faster pixel rate on binned modes git
2024-05-01 15:24 ` [PATCH v5 17/25] dt-bindings: media: imx258: Rename to include vendor prefix git
2024-05-01 15:24 ` [PATCH v5 18/25] dt-bindings: media: imx258: Add alternate compatible strings git
2024-05-01 15:24 ` [PATCH v5 19/25] media: i2c: imx258: Change register settings for variants of the sensor git
2024-05-01 15:24 ` [PATCH v5 20/25] media: i2c: imx258: Make HFLIP and VFLIP controls writable git
2024-05-01 15:24 ` [PATCH v5 21/25] dt-bindings: media: imx258: Add binding for powerdown-gpio git
2024-05-17 8:31 ` Sakari Ailus
2024-05-20 12:50 ` Sakari Ailus
2024-06-02 20:20 ` Luis Garcia
2024-05-20 12:55 ` Ondřej Jirman
2024-05-20 13:19 ` Sakari Ailus [this message]
2024-05-20 13:20 ` Dave Stevenson
2024-05-20 19:04 ` Ondřej Jirman
2024-05-01 15:24 ` [PATCH v5 22/25] media: i2c: imx258: Add support for powerdown gpio git
2024-05-01 15:24 ` [PATCH v5 23/25] media: i2c: imx258: Add support for reset gpio git
2024-05-01 15:24 ` [PATCH v5 24/25] media: i2c: imx258: Use v4l2_link_freq_to_bitmap helper git
2024-05-01 15:24 ` [PATCH v5 25/25] media: i2c: imx258: Convert to new CCI register access helpers git
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZktN7EcXiqupI9Qd@kekkonen.localdomain \
--to=sakari.ailus@linux.intel.com \
--cc=conor+dt@kernel.org \
--cc=dave.stevenson@raspberrypi.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=git@luigi311.com \
--cc=imx@lists.linux.dev \
--cc=jacopo.mondi@ideasonboard.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=megi@xff.cz \
--cc=pavel@ucw.cz \
--cc=phone-devel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).