From: Sakari Ailus <sakari.ailus@iki.fi>
To: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Cc: linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Dafna Hirschfeld <dafna@fastmail.com>,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH v4 1/3] media: v4l2-subdev: Fix v4l2_subdev_state_get_format() documentation
Date: Thu, 9 May 2024 18:29:41 +0000 [thread overview]
Message-ID: <Zj0WFQo0cHReRCcU@valkosipuli.retiisi.eu> (raw)
In-Reply-To: <20240508214045.24716-2-laurent.pinchart+renesas@ideasonboard.com>
Hi Laurent,
Thanks for posting this.
On Thu, May 09, 2024 at 12:40:43AM +0300, Laurent Pinchart wrote:
> The documentation of the v4l2_subdev_state_get_format() macro
> incorrectly references __v4l2_subdev_state_get_format() instead of
> __v4l2_subdev_state_gen_call(). Fix it, and also update the list of
> similar macros to add the missing v4l2_subdev_state_get_interval().
>
> Suggested-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
> include/media/v4l2-subdev.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/media/v4l2-subdev.h b/include/media/v4l2-subdev.h
> index e30c463d90e5..b25b6e97ecbd 100644
> --- a/include/media/v4l2-subdev.h
> +++ b/include/media/v4l2-subdev.h
> @@ -1340,12 +1340,12 @@ void v4l2_subdev_cleanup(struct v4l2_subdev *sd);
> */
> /*
> * Wrap v4l2_subdev_state_get_format(), allowing the function to be called with
> - * two or three arguments. The purpose of the __v4l2_subdev_state_get_format()
> + * two or three arguments. The purpose of the __v4l2_subdev_state_gen_call()
> * macro below is to come up with the name of the function or macro to call,
You could drop "below" here, too: the macro definition is above the text.
Reviewed-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> * using the last two arguments (_stream and _pad). The selected function or
> * macro is then called using the arguments specified by the caller. A similar
> - * arrangement is used for v4l2_subdev_state_crop() and
> - * v4l2_subdev_state_compose() below.
> + * arrangement is used for v4l2_subdev_state_crop(), v4l2_subdev_state_compose()
> + * and v4l2_subdev_state_get_interval() below.
> */
> #define v4l2_subdev_state_get_format(state, pad, ...) \
> __v4l2_subdev_state_gen_call(format, ##__VA_ARGS__, , _pad) \
--
Sakari Ailus
next prev parent reply other threads:[~2024-05-09 18:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-08 21:40 [PATCH v4 0/3] media: v4l2-subdev: Support const-awareness in state accessors Laurent Pinchart
2024-05-08 21:40 ` [PATCH v4 1/3] media: v4l2-subdev: Fix v4l2_subdev_state_get_format() documentation Laurent Pinchart
2024-05-09 18:29 ` Sakari Ailus [this message]
2024-05-09 20:04 ` Laurent Pinchart
2024-05-08 21:40 ` [PATCH v4 2/3] media: v4l2-subdev: Provide const-aware subdev state accessors Laurent Pinchart
2024-05-08 21:40 ` [PATCH v4 3/3] media: rkisp1: Mark subdev state pointers as const Laurent Pinchart
2024-05-10 6:36 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zj0WFQo0cHReRCcU@valkosipuli.retiisi.eu \
--to=sakari.ailus@iki.fi \
--cc=dafna@fastmail.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=tomi.valkeinen@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).