From: Ricardo Ribalda <ribalda@chromium.org>
To: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: cec.h: Fix kerneldoc
Date: Fri, 3 May 2024 13:42:34 +0200 [thread overview]
Message-ID: <CANiDSCsN8yTMBmORrmLvKuMHdJ+Durj8gWV8HK7gGP=x0kqMiw@mail.gmail.com> (raw)
In-Reply-To: <60c08e6b-4a1b-408b-9317-3abe1346cdc5@xs4all.nl>
On Fri, 3 May 2024 at 13:41, Hans Verkuil <hverkuil-cisco@xs4all.nl> wrote:
>
> On 03/05/2024 13:33, Ricardo Ribalda wrote:
> > is_claiming_log_addrs documentation was missing.
> >
> > fix this kernel-doc warning:
> > include/media/cec.h:296: warning: Function parameter or struct member 'is_claiming_log_addrs' not described in 'cec_adapter'
> >
> > Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
>
> Reviewed-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
>
> Hmm, that happens when you don't run your own patches through the build tests :-(
There is an easy way to test your patches with gitlab. No need to
install anything in your computer :P
>
> Regards,
>
> Hans
>
> > ---
> > https://gitlab.freedesktop.org/linux-media/media-staging/-/pipelines/1169148/test_report?job_name=doc
> > ---
> > include/media/cec.h | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/include/media/cec.h b/include/media/cec.h
> > index d3abe84c9c9e..d131514032f2 100644
> > --- a/include/media/cec.h
> > +++ b/include/media/cec.h
> > @@ -187,6 +187,7 @@ struct cec_adap_ops {
> > * in order to transmit or receive CEC messages. This is usually a HW
> > * limitation.
> > * @is_enabled: the CEC adapter is enabled
> > + * @is_claiming_log_addrs: true if cec_claim_log_addrs() is running
> > * @is_configuring: the CEC adapter is configuring (i.e. claiming LAs)
> > * @must_reconfigure: while configuring, the PA changed, so reclaim LAs
> > * @is_configured: the CEC adapter is configured (i.e. has claimed LAs)
> >
> > ---
> > base-commit: 1aa1329a67cc214c3b7bd2a14d1301a795760b07
> > change-id: 20240503-fixdoc-d1380eb243cd
> >
> > Best regards,
>
--
Ricardo Ribalda
prev parent reply other threads:[~2024-05-03 11:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-03 11:33 [PATCH] media: cec.h: Fix kerneldoc Ricardo Ribalda
2024-05-03 11:41 ` Hans Verkuil
2024-05-03 11:42 ` Ricardo Ribalda [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANiDSCsN8yTMBmORrmLvKuMHdJ+Durj8gWV8HK7gGP=x0kqMiw@mail.gmail.com' \
--to=ribalda@chromium.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).