From: Ricardo Ribalda <ribalda@chromium.org>
To: Hidenori Kobayashi <hidenorik@chromium.org>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Bingbu Cao <bingbu.cao@intel.com>,
Tianshu Qiu <tian.shu.qiu@intel.com>,
linux-media@vger.kernel.org,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Hans Verkuil <hverkuil@xs4all.nl>
Subject: Re: [PATCH 2/4] media: intel/ipu6: Switch to RUNTIME_PM_OPS() and SYSTEM_SLEEP_PM_OPS
Date: Wed, 1 May 2024 11:22:26 +0200 [thread overview]
Message-ID: <CANiDSCsJvTV81H_jUWufFGp0TqE7u9t=6MKO8BU294aanomm-Q@mail.gmail.com> (raw)
In-Reply-To: <42svo2ykapj3atpds3dedqzybp4vh7vcvje622n4cxz6geaw2w@mfazrgyw6653>
On Wed, 1 May 2024 at 11:20, Hidenori Kobayashi <hidenorik@chromium.org> wrote:
>
> On Tue, Apr 30, 2024 at 12:55:34PM +0000, Ricardo Ribalda wrote:
> > Replace the old helpers with its modern alternative.
> > Now we do not need to set '__maybe_unused' annotations when we are not
> > enabling the PM configurations.
> >
> > Fixes:
> > drivers/media/pci/intel/ipu6/ipu6.c:841:12: warning: ‘ipu6_runtime_resume’ defined but not used [-Wunused-function]
> > drivers/media/pci/intel/ipu6/ipu6.c:806:12: warning: ‘ipu6_resume’ defined but not used [-Wunused-function]
> > drivers/media/pci/intel/ipu6/ipu6.c:801:12: warning: ‘ipu6_suspend’ defined but not used [-Wunused-function]
> >
> > Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
> > ---
> > drivers/media/pci/intel/ipu6/ipu6.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/media/pci/intel/ipu6/ipu6.c b/drivers/media/pci/intel/ipu6/ipu6.c
> > index 4b1f69d14d71..ff5ca0c52781 100644
> > --- a/drivers/media/pci/intel/ipu6/ipu6.c
> > +++ b/drivers/media/pci/intel/ipu6/ipu6.c
> > @@ -803,7 +803,7 @@ static int ipu6_suspend(struct device *dev)
> > return 0;
> > }
> >
> > -static int ipu6_resume(struct device *dev)
> > +static int __maybe_unused ipu6_resume(struct device *dev)
>
> Doesn't this contradict your commit message?
Ups, good catch!
I started by adding __maybe_unused everywhere and then decided to use
a different macro. Will upload a new revision later today.
>
> > {
> > struct pci_dev *pdev = to_pci_dev(dev);
> > struct ipu6_device *isp = pci_get_drvdata(pdev);
> > @@ -860,8 +860,8 @@ static int ipu6_runtime_resume(struct device *dev)
> > }
> >
> > static const struct dev_pm_ops ipu6_pm_ops = {
> > - SET_SYSTEM_SLEEP_PM_OPS(&ipu6_suspend, &ipu6_resume)
> > - SET_RUNTIME_PM_OPS(&ipu6_suspend, &ipu6_runtime_resume, NULL)
> > + SYSTEM_SLEEP_PM_OPS(&ipu6_suspend, &ipu6_resume)
> > + RUNTIME_PM_OPS(&ipu6_suspend, &ipu6_runtime_resume, NULL)
> > };
> >
> > MODULE_DEVICE_TABLE(pci, ipu6_pci_tbl);
> >
> > --
> > 2.44.0.769.g3c40516874-goog
> >
> >
--
Ricardo Ribalda
next prev parent reply other threads:[~2024-05-01 9:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-30 12:55 [PATCH 0/4] media: Fix compilations with !ACPI !PM and !OF Ricardo Ribalda
2024-04-30 12:55 ` [PATCH 1/4] media: bcm2835-unicam: Fix build with !PM Ricardo Ribalda
2024-04-30 12:55 ` [PATCH 2/4] media: intel/ipu6: Switch to RUNTIME_PM_OPS() and SYSTEM_SLEEP_PM_OPS Ricardo Ribalda
2024-05-01 9:20 ` Hidenori Kobayashi
2024-05-01 9:22 ` Ricardo Ribalda [this message]
2024-04-30 12:55 ` [PATCH 3/4] media: intel/ipu6: Fix direct dependency Kconfig error Ricardo Ribalda
2024-04-30 12:55 ` [PATCH 4/4] media: intel/ipu6: Fix build with !ACPI Ricardo Ribalda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANiDSCsJvTV81H_jUWufFGp0TqE7u9t=6MKO8BU294aanomm-Q@mail.gmail.com' \
--to=ribalda@chromium.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bingbu.cao@intel.com \
--cc=florian.fainelli@broadcom.com \
--cc=hidenorik@chromium.org \
--cc=hverkuil@xs4all.nl \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=mchehab@kernel.org \
--cc=rjui@broadcom.com \
--cc=sakari.ailus@linux.intel.com \
--cc=sbranden@broadcom.com \
--cc=tian.shu.qiu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).