From: Tomasz Figa <tfiga@chromium.org>
To: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Cc: linux-media@vger.kernel.org, Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH] media: videobuf2: core: Drop unneeded forward declaration
Date: Tue, 7 May 2024 14:48:40 +0900 [thread overview]
Message-ID: <CAAFQd5DUKXMkHfGYT-VVfXtFRH42BxwOzKnTBDFaGU7syeRAxA@mail.gmail.com> (raw)
In-Reply-To: <20240505174033.9163-1-laurent.pinchart+renesas@ideasonboard.com>
On Mon, May 6, 2024 at 2:40 AM Laurent Pinchart
<laurent.pinchart+renesas@ideasonboard.com> wrote:
>
> The static __enqueue_in_driver() function is forward-declared
> needlessly, as it isn't called before its definition. Drop the forward
> declaration.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
> drivers/media/common/videobuf2/videobuf2-core.c | 1 -
> 1 file changed, 1 deletion(-)
>
Reviewed-by: Tomasz Figa <tfiga@chromium.org>
Best,
Tomasz
> diff --git a/drivers/media/common/videobuf2/videobuf2-core.c b/drivers/media/common/videobuf2/videobuf2-core.c
> index 358f1fe42975..0217392fcc0d 100644
> --- a/drivers/media/common/videobuf2/videobuf2-core.c
> +++ b/drivers/media/common/videobuf2/videobuf2-core.c
> @@ -199,7 +199,6 @@ module_param(debug, int, 0644);
> })
>
> static void __vb2_queue_cancel(struct vb2_queue *q);
> -static void __enqueue_in_driver(struct vb2_buffer *vb);
>
> static const char *vb2_state_name(enum vb2_buffer_state s)
> {
>
> base-commit: e695668af8523b059127dfa8b261c76e7c9cde10
> --
> Regards,
>
> Laurent Pinchart
>
prev parent reply other threads:[~2024-05-07 5:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-05 17:40 [PATCH] media: videobuf2: core: Drop unneeded forward declaration Laurent Pinchart
2024-05-07 5:48 ` Tomasz Figa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAFQd5DUKXMkHfGYT-VVfXtFRH42BxwOzKnTBDFaGU7syeRAxA@mail.gmail.com \
--to=tfiga@chromium.org \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).