From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: R Sundar <prosunofficial@gmail.com>,
mripard@kernel.org, mchehab@kernel.org
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
skhan@linuxfoundation.org, javier.carrasco.cruz@gmail.com,
Julia Lawall <julia.lawall@inria.fr>
Subject: Re: [PATCH linux-next] media:cdns-csi2tx: replace of_node_put() with __free
Date: Mon, 29 Apr 2024 20:40:59 +0200 [thread overview]
Message-ID: <6df5d715-3e31-40a5-9db3-2c3b9f12efac@wanadoo.fr> (raw)
In-Reply-To: <20240429171543.13032-1-prosunofficial@gmail.com>
Le 29/04/2024 à 19:15, R Sundar a écrit :
> Use the new cleanup magic to replace of_node_put() with
> __free(device_node) marking to auto release when they get out of scope.
>
> Suggested-by: Julia Lawall <julia.lawall@inria.fr>
> Signed-off-by: R Sundar <prosunofficial@gmail.com>
> ---
> drivers/media/platform/cadence/cdns-csi2tx.c | 19 +++++++------------
> 1 file changed, 7 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/media/platform/cadence/cdns-csi2tx.c b/drivers/media/platform/cadence/cdns-csi2tx.c
> index 3d98f91f1bee..88aed2f299fd 100644
> --- a/drivers/media/platform/cadence/cdns-csi2tx.c
> +++ b/drivers/media/platform/cadence/cdns-csi2tx.c
> @@ -496,48 +496,43 @@ static int csi2tx_get_resources(struct csi2tx_priv *csi2tx,
> static int csi2tx_check_lanes(struct csi2tx_priv *csi2tx)
> {
> struct v4l2_fwnode_endpoint v4l2_ep = { .bus_type = 0 };
> - struct device_node *ep;
> int ret, i;
> -
> - ep = of_graph_get_endpoint_by_regs(csi2tx->dev->of_node, 0, 0);
> + struct device_node *ep __free(device_node) =
> + of_graph_get_endpoint_by_regs(csi2tx->dev->of_node, 0, 0);
> +
> if (!ep)
> return -EINVAL;
>
> ret = v4l2_fwnode_endpoint_parse(of_fwnode_handle(ep), &v4l2_ep);
> if (ret) {
> dev_err(csi2tx->dev, "Could not parse v4l2 endpoint\n");
> - goto out;
> + return ret;
> }
>
> if (v4l2_ep.bus_type != V4L2_MBUS_CSI2_DPHY) {
> dev_err(csi2tx->dev, "Unsupported media bus type: 0x%x\n",
> v4l2_ep.bus_type);
> - ret = -EINVAL;
> - goto out;
> + return -EINVAL;
> }
>
> csi2tx->num_lanes = v4l2_ep.bus.mipi_csi2.num_data_lanes;
> if (csi2tx->num_lanes > csi2tx->max_lanes) {
> dev_err(csi2tx->dev,
> "Current configuration uses more lanes than supported\n");
> - ret = -EINVAL;
> - goto out;
> + return -EINVAL;
> }
>
> for (i = 0; i < csi2tx->num_lanes; i++) {
> if (v4l2_ep.bus.mipi_csi2.data_lanes[i] < 1) {
> dev_err(csi2tx->dev, "Invalid lane[%d] number: %u\n",
> i, v4l2_ep.bus.mipi_csi2.data_lanes[i]);
> - ret = -EINVAL;
> - goto out;
> + return -EINVAL;
> }
> }
>
> memcpy(csi2tx->lanes, v4l2_ep.bus.mipi_csi2.data_lanes,
> sizeof(csi2tx->lanes));
>
> -out:
> - of_node_put(ep);
> return ret;
Hi,
Nit: return 0; ?
CJ
> }
>
next prev parent reply other threads:[~2024-04-29 18:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-29 17:15 [PATCH linux-next] media:cdns-csi2tx: replace of_node_put() with __free R Sundar
2024-04-29 18:40 ` Christophe JAILLET [this message]
2024-04-30 13:07 ` R Sundar
2024-04-30 17:23 ` Julia Lawall
2024-05-01 3:31 ` R Sundar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6df5d715-3e31-40a5-9db3-2c3b9f12efac@wanadoo.fr \
--to=christophe.jaillet@wanadoo.fr \
--cc=javier.carrasco.cruz@gmail.com \
--cc=julia.lawall@inria.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=mripard@kernel.org \
--cc=prosunofficial@gmail.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).