From: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
To: linux-media@vger.kernel.org
Cc: linux-renesas-soc@vger.kernel.org,
Sakari Ailus <sakari.ailus@iki.fi>,
Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Dafna Hirschfeld <dafna@fastmail.com>,
linux-rockchip@lists.infradead.org
Subject: [PATCH v3 0/2] media: v4l2-subdev: Support const-awareness in state accessors
Date: Tue, 7 May 2024 19:19:05 +0300 [thread overview]
Message-ID: <20240507161907.27747-1-laurent.pinchart+renesas@ideasonboard.com> (raw)
This small patch series comes from a mild annoyance I experienced during
a recent patch review, where I wanted to ask for a pointer to a
v4l2_subdev_state used to access the state in a read-only fashion to be
made const. This wasn't possible as the state accessors functions take a
non-const state pointer, in order to return pointers to mutable formats
and selection rectangles.
Patch 1/2 improves the state accessors to support const states, in the
same wait as the recently introduced container_of_const() macro.
Bikeshedding of the internal macro and function names is expected. Patch
2/2 then shows how this can be used in one driver.
Compared to v2, patch 1/2 uses explicit types as _Generic() selectors,
and fixes an issue with the const cast of the value.
Laurent Pinchart (2):
media: v4l2-subdev: Provide const-aware subdev state accessors
media: rkisp1: Mark subdev state pointers as const
.../platform/rockchip/rkisp1/rkisp1-isp.c | 8 ++--
.../platform/rockchip/rkisp1/rkisp1-resizer.c | 8 ++--
include/media/v4l2-subdev.h | 40 +++++++++++++------
3 files changed, 35 insertions(+), 21 deletions(-)
base-commit: e695668af8523b059127dfa8b261c76e7c9cde10
--
Regards,
Laurent Pinchart
next reply other threads:[~2024-05-07 16:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-07 16:19 Laurent Pinchart [this message]
2024-05-07 16:19 ` [PATCH v3 1/2] media: v4l2-subdev: Provide const-aware subdev state accessors Laurent Pinchart
2024-05-08 18:44 ` Sakari Ailus
2024-05-08 18:48 ` Tomi Valkeinen
2024-05-08 21:02 ` Laurent Pinchart
2024-05-07 16:19 ` [PATCH v3 2/2] media: rkisp1: Mark subdev state pointers as const Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240507161907.27747-1-laurent.pinchart+renesas@ideasonboard.com \
--to=laurent.pinchart+renesas@ideasonboard.com \
--cc=dafna@fastmail.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=sakari.ailus@iki.fi \
--cc=tomi.valkeinen@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).