From: Mauro Carvalho Chehab <mchehab@kernel.org>
To: Ricardo Ribalda <ribalda@chromium.org>
Cc: Florian Fainelli <florian.fainelli@broadcom.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Bingbu Cao <bingbu.cao@intel.com>,
Tianshu Qiu <tian.shu.qiu@intel.com>,
linux-media@vger.kernel.org,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Hans Verkuil <hverkuil@xs4all.nl>
Subject: Re: [PATCH v2 1/5] media: bcm2835-unicam: Fix build with !PM
Date: Thu, 2 May 2024 11:11:30 +0100 [thread overview]
Message-ID: <20240502111130.769402fa@sal.lan> (raw)
In-Reply-To: <20240501-fix-ipu6-v2-1-a5629a37a0fb@chromium.org>
Em Wed, 01 May 2024 13:08:09 +0000
Ricardo Ribalda <ribalda@chromium.org> escreveu:
> The driver can only match the device vide the DT table, so the table
> should always be used, of_match_ptr does not make sense here.
>
> Fixes:
> drivers/media/platform/broadcom/bcm2835-unicam.c:2724:34: warning: ‘unicam_of_match’ defined but not used [-Wunused-const-variable=]
Be careful here: Fixes: <patch> is a tag used by stable people to
identify if a patch needs to be backported. Using a Fixes: may cause
such scripts to break.
(it caused a problem on my apply patch script, as it does reorder
fixes tag).
No need to resend it, as I can fix it when applying, but next time
please use something like:
It fixes this warning:
drivers/media/platform/broadcom/bcm2835-unicam.c:2724:34: warning: ‘unicam_of_match’ defined but not used [-Wunused-const-variable=]
(or some other similar word that won't be using a defined meta tag
with a different meaning).
Regards,
Mauro
>
> Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
> ---
> drivers/media/platform/broadcom/bcm2835-unicam.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/broadcom/bcm2835-unicam.c b/drivers/media/platform/broadcom/bcm2835-unicam.c
> index bd2bbb53070e..c590e26fe2cf 100644
> --- a/drivers/media/platform/broadcom/bcm2835-unicam.c
> +++ b/drivers/media/platform/broadcom/bcm2835-unicam.c
> @@ -2733,7 +2733,7 @@ static struct platform_driver unicam_driver = {
> .driver = {
> .name = UNICAM_MODULE_NAME,
> .pm = pm_ptr(&unicam_pm_ops),
> - .of_match_table = of_match_ptr(unicam_of_match),
> + .of_match_table = unicam_of_match,
> },
> };
>
>
next prev parent reply other threads:[~2024-05-02 10:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-01 13:08 [PATCH v2 0/5] media: Fix compilations with !ACPI !PM and !OF Ricardo Ribalda
2024-05-01 13:08 ` [PATCH v2 1/5] media: bcm2835-unicam: Fix build with !PM Ricardo Ribalda
2024-05-02 10:11 ` Mauro Carvalho Chehab [this message]
2024-05-01 13:08 ` [PATCH v2 2/5] media: bcm2835-unicam: Include v4l2-subdev.h Ricardo Ribalda
2024-05-01 13:08 ` [PATCH v2 3/5] media: intel/ipu6: Switch to RUNTIME_PM_OPS() and SYSTEM_SLEEP_PM_OPS Ricardo Ribalda
2024-05-01 13:08 ` [PATCH v2 4/5] media: intel/ipu6: Fix direct dependency Kconfig error Ricardo Ribalda
2024-05-01 13:08 ` [PATCH v2 5/5] media: intel/ipu6: Fix build with !ACPI Ricardo Ribalda
2024-05-02 8:26 ` [PATCH v2 0/5] media: Fix compilations with !ACPI !PM and !OF Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240502111130.769402fa@sal.lan \
--to=mchehab@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bingbu.cao@intel.com \
--cc=florian.fainelli@broadcom.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=ribalda@chromium.org \
--cc=rjui@broadcom.com \
--cc=sakari.ailus@linux.intel.com \
--cc=sbranden@broadcom.com \
--cc=tian.shu.qiu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).