From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Cc: linux-media@vger.kernel.org,
Florian Fainelli <florian.fainelli@broadcom.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Naushir Patuck <naush@raspberrypi.com>,
Dave Stevenson <dave.stevenson@raspberrypi.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] media: bcm2835-unicam: Include v4l2-subdev.h
Date: Wed, 1 May 2024 14:55:59 +0300 [thread overview]
Message-ID: <20240501115559.GI17852@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20240501114715.GG17852@pendragon.ideasonboard.com>
On Wed, May 01, 2024 at 02:47:15PM +0300, Laurent Pinchart wrote:
> On Wed, May 01, 2024 at 01:07:29PM +0200, Ricardo Ribalda Delgado wrote:
> > Hi Laurent
> >
> > I have to send a v2 of
> > https://patchwork.linuxtv.org/project/linux-media/list/?series=12759 I
> > can include this patch in that set if you want
>
> Fine with me.
Assuming your v2 will be merged in v6.10.
> > On Tue, Apr 30, 2024 at 11:39 PM Laurent Pinchart wrote:
> > >
> > > The unicam driver uses the v4l2_subdev structure. Include the
> > > corresponding header instead of relying on indirect includes.
> > >
> > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > > Reported-by: kernel test robot <lkp@intel.com>
> > Reviewed-by: Ricardo Ribalda <ribalda@chromium.org>
> > > Closes: https://lore.kernel.org/oe-kbuild-all/202404302324.8aTC84kE-lkp@intel.com/
> > > ---
> > > drivers/media/platform/broadcom/bcm2835-unicam.c | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/drivers/media/platform/broadcom/bcm2835-unicam.c b/drivers/media/platform/broadcom/bcm2835-unicam.c
> > > index c590e26fe2cf..3c7878d8d79b 100644
> > > --- a/drivers/media/platform/broadcom/bcm2835-unicam.c
> > > +++ b/drivers/media/platform/broadcom/bcm2835-unicam.c
> > > @@ -55,6 +55,7 @@
> > > #include <media/v4l2-ioctl.h>
> > > #include <media/v4l2-fwnode.h>
> > > #include <media/v4l2-mc.h>
> > > +#include <media/v4l2-subdev.h>
> > > #include <media/videobuf2-dma-contig.h>
> > >
> > > #include "bcm2835-unicam-regs.h"
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2024-05-01 11:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-30 21:31 [PATCH 0/2] media: bcm2835-unicam: Fix compilation errors and warnings Laurent Pinchart
2024-04-30 21:36 ` [PATCH 1/2] media: bcm2835-unicam: Drop usage of of_match_ptr() Laurent Pinchart
2024-04-30 21:36 ` [PATCH 2/2] media: bcm2835-unicam: Include v4l2-subdev.h Laurent Pinchart
2024-05-01 11:07 ` Ricardo Ribalda Delgado
2024-05-01 11:47 ` Laurent Pinchart
2024-05-01 11:55 ` Laurent Pinchart [this message]
2024-05-01 11:03 ` [PATCH 1/2] media: bcm2835-unicam: Drop usage of of_match_ptr() Ricardo Ribalda Delgado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240501115559.GI17852@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=dave.stevenson@raspberrypi.com \
--cc=florian.fainelli@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=naush@raspberrypi.com \
--cc=ricardo.ribalda@gmail.com \
--cc=rjui@broadcom.com \
--cc=sakari.ailus@linux.intel.com \
--cc=sbranden@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).