From: Ricardo Ribalda <ribalda@chromium.org>
To: Mauro Carvalho Chehab <mchehab@kernel.org>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>
Cc: linux-media@vger.kernel.org,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Hans Verkuil <hverkuil@xs4all.nl>,
Ricardo Ribalda <ribalda@chromium.org>
Subject: [PATCH 1/3] media: bcm2835-unicam: Fix error handling for platform_get_irq
Date: Tue, 30 Apr 2024 07:51:26 +0000 [thread overview]
Message-ID: <20240430-fix-broad-v1-1-cf3b81bf97ff@chromium.org> (raw)
In-Reply-To: <20240430-fix-broad-v1-0-cf3b81bf97ff@chromium.org>
platform_get_irq() cannot return the value 0.
If it returns -EPROBE_DEFER, we need to populate the error code upwards
to retry probing once the irq handler is ready.
Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
---
drivers/media/platform/broadcom/bcm2835-unicam.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/media/platform/broadcom/bcm2835-unicam.c b/drivers/media/platform/broadcom/bcm2835-unicam.c
index bd2bbb53070e..2a3a27ac70ba 100644
--- a/drivers/media/platform/broadcom/bcm2835-unicam.c
+++ b/drivers/media/platform/broadcom/bcm2835-unicam.c
@@ -2660,9 +2660,10 @@ static int unicam_probe(struct platform_device *pdev)
}
ret = platform_get_irq(pdev, 0);
- if (ret <= 0) {
+ if (ret < 0) {
dev_err(&pdev->dev, "No IRQ resource\n");
- ret = -EINVAL;
+ if (ret != -EPROBE_DEFER)
+ ret = -EINVAL;
goto err_unicam_put;
}
--
2.44.0.769.g3c40516874-goog
next prev parent reply other threads:[~2024-04-30 7:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-30 7:51 [PATCH 0/3] media: bcm2835-unicam: Improve error handling during probe Ricardo Ribalda
2024-04-30 7:51 ` Ricardo Ribalda [this message]
2024-05-06 18:00 ` [PATCH 1/3] media: bcm2835-unicam: Fix error handling for platform_get_irq Laurent Pinchart
2024-04-30 7:51 ` [PATCH 2/3] media: bcm2835-unicam: Do not print error when irq not found Ricardo Ribalda
2024-05-06 18:01 ` Laurent Pinchart
2024-04-30 7:51 ` [PATCH 3/3] media: bcm2835-unicam: Do not replace IRQ retcode during probe Ricardo Ribalda
2024-05-06 18:03 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240430-fix-broad-v1-1-cf3b81bf97ff@chromium.org \
--to=ribalda@chromium.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=florian.fainelli@broadcom.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=mchehab@kernel.org \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).