From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Andrey Skvortsov" <andrej.skvortzov@gmail.com>,
"Sakari Ailus" <sakari.ailus@linux.intel.com>,
"Alain Volmat" <alain.volmat@foss.st.com>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, "Ondřej Jirman" <megi@xff.cz>,
"Pavel Machek" <pavel@ucw.cz>,
"Arnaud Ferraris" <arnaud.ferraris@collabora.com>
Subject: Re: [PATCH v3 1/2] dt-bindings: media: i2c: add galaxycore,gc2145 DVP bus support
Date: Sun, 5 May 2024 12:23:28 +0200 [thread overview]
Message-ID: <10c9c895-d877-4aaf-89c4-79d53b00fe50@linaro.org> (raw)
In-Reply-To: <ZjdLohzrTA80sE8M@skv.local>
On 05/05/2024 11:04, Andrey Skvortsov wrote:
> Hi Krzysztof,
>
> On 24-05-05 10:20, Krzysztof Kozlowski wrote:
>> On 04/05/2024 18:41, Andrey Skvortsov wrote:
>>> Signed-off-by: Andrey Skvortsov <andrej.skvortzov@gmail.com>
>>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>
>> Not true. I never acked patch with empty commit and such content.
>>
> Sorry about that. You've acked v1, so I've kept it. I'll remove it in
> v4.
I acked entirely different version. It had even commit msg. Empty commit
would have never been acked.
>
>> Drop fake tag and send new version with proper commit msg and proper
>> changelog under ---.
> There is changelog in cover letter. Should I include corresponding changelog in each
> patch as well?
It's fine there although nothing explains why you did these changes or
why commit msg is gone.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-05-05 10:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-04 16:41 [PATCH v3 0/2] media: gc2145: add basic dvp bus support Andrey Skvortsov
2024-05-04 16:41 ` [PATCH v3 1/2] dt-bindings: media: i2c: add galaxycore,gc2145 DVP " Andrey Skvortsov
2024-05-05 8:20 ` Krzysztof Kozlowski
2024-05-05 8:22 ` Krzysztof Kozlowski
2024-05-05 9:04 ` Andrey Skvortsov
2024-05-05 10:23 ` Krzysztof Kozlowski [this message]
2024-05-04 16:41 ` [PATCH v3 2/2] media: gc2145: implement basic dvp " Andrey Skvortsov
2024-05-05 8:21 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10c9c895-d877-4aaf-89c4-79d53b00fe50@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alain.volmat@foss.st.com \
--cc=andrej.skvortzov@gmail.com \
--cc=arnaud.ferraris@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=megi@xff.cz \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).