From: Greg Ungerer <gerg@kernel.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-m68k@lists.linux-m68k.org,
Greg Ungerer <gerg@linux-m68k.org>,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] m68knommu: improve config ROM setting defaults
Date: Wed, 13 Sep 2023 23:05:58 +1000 [thread overview]
Message-ID: <e5ce60b3-f666-30ab-dc42-a7ebd330dfd0@kernel.org> (raw)
In-Reply-To: <CAMuHMdUhpXWfvu+sF+ARaXbeMrkxNA=e-tDNE2+nZberqqyCYQ@mail.gmail.com>
Hi Geert,
On 13/9/23 23:00, Geert Uytterhoeven wrote:
> Hi Greg,
>
> Thanks for your patch!
>
> On Wed, Sep 13, 2023 at 2:52 PM Greg Ungerer <gerg@kernel.org> wrote:
>> From: Greg Ungerer <gerg@linux-m68k.org>
>>
>> The ROM region configuration settings used on some nommu m68k systems
>> (historically mostly 68328 (Dragonball) CPUs) default to an address
>> of 0. That can easily clash with default RAM address settings which
>> also default to 0. Of course that is invalid and those ranges overlap,
>> but if you make no value selection that is what you end up with. Those
>> default values produce a valid configuration but will fail compilation
>> like this:
>>
>> m68k-linux-ld: section .rodata VMA [0000000000001000,0000000000262227] overlaps section .text VMA [0000000000000400,0000000000455e7f]
>>
>> Looking at the platforms that use the ROM region configuration settings
>> it is clear that we can choose much better defaults than 0. By far the
>> most comman ROM region settings are these:
>
> common
>
>> CONFIG_ROMVEC=0x10c10000
>> CONFIG_ROMSTART=0x10c10400
>>
>> So lets make these the default values.
>>
>> It is still possible to configure overlapping ROM and RAM regions, but
>> at least the defult selections are now valid.
>
> default
And I thought I spell checked them before sending :-(
I'll fix those up, thanks!
Regards
Greg
>>
>> Reported-by: kernel test robot <lkp@intel.com>
>> Closes: https://lore.kernel.org/oe-kbuild-all/202305301407.z33zOjcG-lkp@intel.com/
>> Signed-off-by: Greg Ungerer <gerg@linux-m68k.org>
>
> Gr{oetje,eeting}s,
>
> Geert
>
prev parent reply other threads:[~2023-09-13 13:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-13 12:51 [PATCH] m68knommu: improve config ROM setting defaults Greg Ungerer
2023-09-13 13:00 ` Geert Uytterhoeven
2023-09-13 13:05 ` Greg Ungerer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5ce60b3-f666-30ab-dc42-a7ebd330dfd0@kernel.org \
--to=gerg@kernel.org \
--cc=geert@linux-m68k.org \
--cc=gerg@linux-m68k.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).