From: Geert Uytterhoeven <geert@linux-m68k.org>
To: linux-m68k@lists.linux-m68k.org
Cc: Arnd Bergmann <arnd@arndb.de>, Finn Thain <fthain@linux-m68k.org>,
Michael Schmitz <schmitzmic@gmail.com>,
Philip Blundell <philb@gnu.org>,
Greg Ungerer <gerg@linux-m68k.org>,
Joshua Thompson <funaho@jurai.org>, Sam Creasey <sammy@sammy.net>,
Laurent Vivier <laurent@vivier.eu>,
linux-kernel@vger.kernel.org,
Geert Uytterhoeven <geert@linux-m68k.org>
Subject: [PATCH 45/52] m68k: sun3: Annotate prom_printf() with __printf()
Date: Thu, 7 Sep 2023 15:41:46 +0200 [thread overview]
Message-ID: <c2ad40d765b52387da89a4c94a96ad906df8754b.1694093327.git.geert@linux-m68k.org> (raw)
In-Reply-To: <cover.1694093327.git.geert@linux-m68k.org>
When building with W=1:
arch/m68k/sun3/prom/printf.c: In function ‘prom_printf’:
arch/m68k/sun3/prom/printf.c:35:9: warning: function ‘prom_printf’ might be a candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format]
35 | vsprintf(ppbuf, fmt, args);
| ^~~~~~~~
Fix this by annotating prom_printf() with __printf(1, 2).
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
arch/m68k/include/asm/oplib.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/arch/m68k/include/asm/oplib.h b/arch/m68k/include/asm/oplib.h
index 48cb4fd09f8d9cce..6d5ea67c65d044c1 100644
--- a/arch/m68k/include/asm/oplib.h
+++ b/arch/m68k/include/asm/oplib.h
@@ -9,6 +9,8 @@
#ifndef __SPARC_OPLIB_H
#define __SPARC_OPLIB_H
+#include <linux/compiler.h>
+
#include <asm/openprom.h>
/* The master romvec pointer... */
@@ -149,7 +151,7 @@ extern char prom_getchar(void);
extern void prom_putchar(char character);
/* Prom's internal printf routine, don't use in kernel/boot code. */
-void prom_printf(char *fmt, ...);
+__printf(1, 2) void prom_printf(char *fmt, ...);
/* Query for input device type */
--
2.34.1
next prev parent reply other threads:[~2023-09-07 15:45 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-07 13:41 [PATCH 00/52] m68k: W=1 fixes Geert Uytterhoeven
2023-09-07 13:41 ` [PATCH 01/52] m68k: kernel: Add missing asmlinkage to do_notify_resume() Geert Uytterhoeven
2023-09-07 13:41 ` [PATCH 02/52] m68k: kernel: Include <linux/cpu.h> for trap_init() Geert Uytterhoeven
2023-09-07 13:41 ` [PATCH 03/52] m68k: kernel: Make bad_super_trap() static Geert Uytterhoeven
2023-09-07 13:41 ` [PATCH 04/52] m68k: kernel: Add and use <asm/syscalls.h> Geert Uytterhoeven
2023-09-07 13:41 ` [PATCH 05/52] m68k: kernel: Add and use "ints.h" Geert Uytterhoeven
2023-09-07 13:41 ` [PATCH 06/52] m68k: kernel: Add and use "process.h" Geert Uytterhoeven
2023-09-11 13:42 ` Greg Ungerer
2023-09-11 13:51 ` Geert Uytterhoeven
2023-09-07 13:41 ` [PATCH 07/52] m68k: kernel: Add and use "ptrace.h" Geert Uytterhoeven
2023-09-07 13:41 ` [PATCH 08/52] m68k: kernel: Add and use "signal.h" Geert Uytterhoeven
2023-09-07 13:41 ` [PATCH 09/52] m68k: kernel: Add and use "traps.h" Geert Uytterhoeven
2023-09-07 13:41 ` [PATCH 10/52] m68k: kernel: Add and use "vectors.h" Geert Uytterhoeven
2023-09-07 13:41 ` [PATCH 11/52] m68k: mm: Include <asm/hwtest.h> for hwreg_() Geert Uytterhoeven
2023-09-07 13:41 ` [PATCH 12/52] m68k: mm: Move paging_init() to common <asm/pgtable.h> Geert Uytterhoeven
2023-09-07 13:41 ` [PATCH 13/52] m68k: mm: Add and use "fault.h" Geert Uytterhoeven
2023-09-07 13:41 ` [PATCH 14/52] m68k: emu: Remove unused vsnprintf() return value in nfprint() Geert Uytterhoeven
2023-09-07 13:41 ` [PATCH 15/52] m68k: emu: Mark version[] __maybe_unused Geert Uytterhoeven
2023-09-09 8:28 ` Arnd Bergmann
2023-09-09 12:12 ` Geert Uytterhoeven
2023-09-09 14:07 ` Arnd Bergmann
2023-09-11 13:41 ` Geert Uytterhoeven
2023-09-07 13:41 ` [PATCH 16/52] m68k: amiga: pcmcia: Replace set but not used variable by READ_ONCE() Geert Uytterhoeven
2023-09-07 13:41 ` [PATCH 17/52] m68k: amiga: Add and use "amiga.h" Geert Uytterhoeven
2023-09-07 13:41 ` [PATCH 18/52] m68k: atari: Document data parameter of stdma_try_lock() Geert Uytterhoeven
2023-09-07 13:41 ` [PATCH 19/52] m68k: atari: Make ikbd_reset() static Geert Uytterhoeven
2023-09-07 13:41 ` [PATCH 20/52] m68k: atari: Make atari_platform_init() static Geert Uytterhoeven
2023-09-07 13:41 ` [PATCH 21/52] m68k: atari: Make atari_stram_map_pages() static Geert Uytterhoeven
2023-09-07 13:41 ` [PATCH 22/52] m68k: atari: Add and use "atari.h" Geert Uytterhoeven
2023-09-07 23:57 ` Finn Thain
2023-09-08 0:46 ` Michael Schmitz
2023-09-08 1:05 ` Finn Thain
2023-09-08 7:13 ` Geert Uytterhoeven
2023-09-07 13:41 ` [PATCH 23/52] m68k: apollo: Remove unused debug console functions Geert Uytterhoeven
2023-09-07 13:41 ` [PATCH 24/52] m68k: apollo: Make local reset, serial, and irq functions static Geert Uytterhoeven
2023-09-07 13:41 ` [PATCH 25/52] m68k: apollo: Replace set but not used variable by READ_ONCE() Geert Uytterhoeven
2023-09-07 23:37 ` Finn Thain
2023-09-08 6:51 ` Geert Uytterhoeven
2023-09-09 8:35 ` Arnd Bergmann
2023-09-07 13:41 ` [PATCH 26/52] m68k: apollo: Add and use "apollo.h" Geert Uytterhoeven
2023-09-07 13:41 ` [PATCH 27/52] m68k: bvme6000: Make bvme6000_abort_int() static Geert Uytterhoeven
2023-09-07 13:41 ` [PATCH 28/52] m68k: hp300: Include "time.h" for hp300_sched_init() Geert Uytterhoeven
2023-09-07 13:41 ` [PATCH 29/52] m68k: mac: Remove unused sine_data[] Geert Uytterhoeven
2023-09-07 13:41 ` [PATCH 30/52] m68k: mac: Remove unused yday in unmktime() Geert Uytterhoeven
2023-09-07 13:41 ` [PATCH 31/52] m68k: mac: Make mac_platform_init() static Geert Uytterhoeven
2023-09-07 13:41 ` [PATCH 32/52] m68k: mac: Add and use "mac.h" Geert Uytterhoeven
2023-09-07 23:44 ` Finn Thain
2023-09-08 7:15 ` Geert Uytterhoeven
2023-09-08 22:59 ` Finn Thain
2023-09-09 12:10 ` Geert Uytterhoeven
2023-09-07 13:41 ` [PATCH 33/52] m68k: mvme147: Make mvme147_init_IRQ() static Geert Uytterhoeven
2023-09-07 13:41 ` [PATCH 34/52] m68k: mvme16x: Remove unused sink in mvme16x_cons_write() Geert Uytterhoeven
2023-09-07 13:41 ` [PATCH 35/52] m68k: mvme16x: Add and use "mvme16x.h" Geert Uytterhoeven
2023-09-07 13:41 ` [PATCH 36/52] m68k: q40: Add and use "q40.h" Geert Uytterhoeven
2023-09-07 13:41 ` [PATCH 37/52] m68k: sun3/3x: Include <asm/config.h> for config_sun3*() Geert Uytterhoeven
2023-09-07 13:41 ` [PATCH 38/52] m68k: sun3: Improve Sun3/3x DVMA abstraction in <asm/dvma.h> Geert Uytterhoeven
2023-09-07 13:41 ` [PATCH 39/52] m68k: sun3: Fix context restore in flush_tlb_range() Geert Uytterhoeven
2023-09-07 13:41 ` [PATCH 40/52] m68k: sun3: Fix signature of sun3_get_model() Geert Uytterhoeven
2023-09-07 13:41 ` [PATCH 41/52] m68k: sun3: Add missing asmlinkage to sun3_init() Geert Uytterhoeven
2023-09-07 13:41 ` [PATCH 42/52] m68k: sun3: Remove unused orig_baddr in free_baddr() Geert Uytterhoeven
2023-09-07 13:41 ` [PATCH 43/52] m68k: sun3: Remove unused start_page in sun3_bootmem_alloc() Geert Uytterhoeven
2023-09-07 13:41 ` [PATCH 44/52] m68k: sun3: Remove unused vsprintf() return value in prom_printf() Geert Uytterhoeven
2023-09-07 13:41 ` Geert Uytterhoeven [this message]
2023-09-07 13:41 ` [PATCH 46/52] m68k: sun3: Make print_pte() static Geert Uytterhoeven
2023-09-07 13:41 ` [PATCH 47/52] m68k: sun3: Make sun3_platform_init() static Geert Uytterhoeven
2023-09-07 13:41 ` [PATCH 48/52] m68k: sun3x: Fix signature of sun3_leds() Geert Uytterhoeven
2023-09-07 13:41 ` [PATCH 49/52] m68k: sun3x: Do not mark dvma_map_iommu() inline Geert Uytterhoeven
2023-09-07 13:41 ` [PATCH 50/52] m68k: sun3x: Make sun3x_halt() static Geert Uytterhoeven
2023-09-07 13:41 ` [PATCH 51/52] m68k: sun3x: Make dvma_print() static Geert Uytterhoeven
2023-09-07 13:41 ` [PATCH 52/52] m68k: sun3/3x: Add and use "sun3.h" Geert Uytterhoeven
2023-09-09 8:37 ` [PATCH 00/52] m68k: W=1 fixes Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2ad40d765b52387da89a4c94a96ad906df8754b.1694093327.git.geert@linux-m68k.org \
--to=geert@linux-m68k.org \
--cc=arnd@arndb.de \
--cc=fthain@linux-m68k.org \
--cc=funaho@jurai.org \
--cc=gerg@linux-m68k.org \
--cc=laurent@vivier.eu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=philb@gnu.org \
--cc=sammy@sammy.net \
--cc=schmitzmic@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).