From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Michael Schmitz <schmitzmic@gmail.com>
Cc: dlemoal@kernel.org, linux-ide@vger.kernel.org,
linux-m68k@vger.kernel.org, will@sowerbutts.com,
rz@linux-m68k.org, stable@vger.kernel.org,
Finn Thain <fthain@linux-m68k.org>
Subject: Re: [PATCH v3 1/2] ata: pata_falcon: fix IO base selection for Q40
Date: Tue, 22 Aug 2023 10:39:40 +0200 [thread overview]
Message-ID: <CAMuHMdUokks=1Z9vDkzYdqTXEWyhT5WZk8w5FgmppZBeGP2nrg@mail.gmail.com> (raw)
In-Reply-To: <fd0b71fa-783e-41c0-ab2b-02656286d2ab@gmail.com>
Hi Michael,
On Tue, Aug 22, 2023 at 10:27 AM Michael Schmitz <schmitzmic@gmail.com> wrote:
> Am 21.08.2023 um 19:50 schrieb Geert Uytterhoeven:
> >> + ap->ioaddr.data_addr = (void __iomem *)base_mem_res->start;
> >> +
> >> + if (base_res) { /* only Q40 has IO resources */
> >> + io_offset = 0x10000;
> >> + reg_scale = 1;
> >> + base = (void __iomem *)base_res->start;
> >> + ctl_base = (void __iomem *)ctl_res->start;
> >> +
> >> + ata_port_desc(ap, "cmd %pa ctl %pa",
> >> + &base_res->start,
> >> + &ctl_res->start);
> >
> > This can be moved outside the else, using %px to format base and
> > ctl_base.
>
> I get a checkpatch warning for %px, but not for %pa (used for .
> &ap->ioaddr.data_addr). What gives?
>
> WARNING: Using vsprintf specifier '%px' potentially exposes the kernel
> memory layout, if you don't really need the address please consider
> using '%p'.
> #148: FILE: drivers/ata/pata_falcon.c:194:
> + ata_port_desc(ap, "cmd %px ctl %px data %pa",
> + base, ctl_base, &ap->ioaddr.data_addr);
You can ignore this.
%p prints obfuscated pointer values, so they are useless here.
%px prints an unobfuscated pointer value, which is fine here, as it's
not a pointer to kernel memory that an attacker can use, but just the
virtual address of an I/O device mapped one-to-one.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2023-08-22 8:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-18 23:49 [PATCH v3 0/2] Q40 IDE fixes Michael Schmitz
2023-08-18 23:49 ` [PATCH v3 1/2] ata: pata_falcon: fix IO base selection for Q40 Michael Schmitz
2023-08-21 7:50 ` Geert Uytterhoeven
2023-08-21 23:57 ` Michael Schmitz
2023-08-22 7:05 ` Geert Uytterhoeven
2023-08-22 7:27 ` Michael Schmitz
2023-08-22 8:27 ` Michael Schmitz
2023-08-22 8:39 ` Geert Uytterhoeven [this message]
2023-08-18 23:49 ` [PATCH v3 2/2] ata: pata_falcon: add data_swab option to byte-swap disk data Michael Schmitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdUokks=1Z9vDkzYdqTXEWyhT5WZk8w5FgmppZBeGP2nrg@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=dlemoal@kernel.org \
--cc=fthain@linux-m68k.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=rz@linux-m68k.org \
--cc=schmitzmic@gmail.com \
--cc=stable@vger.kernel.org \
--cc=will@sowerbutts.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).