From: Greg Ungerer <gerg@linux-m68k.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>,
Jiri Slaby <jirislaby@kernel.org>
Cc: Thomas Huth <thuth@redhat.com>,
linux-m68k@lists.linux-m68k.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH] drivers/tty/serial: Remove unused function early_mcf_setup
Date: Tue, 20 Feb 2024 23:55:48 +1000 [thread overview]
Message-ID: <590107ef-16f1-4680-8fd6-11df838ce14a@linux-m68k.org> (raw)
In-Reply-To: <CAMuHMdXc=rR9udEmMsCJof+sCxdoJryF49-Gy9j=DJqiHyUsvQ@mail.gmail.com>
On 20/2/24 20:23, Geert Uytterhoeven wrote:
> On Tue, Feb 20, 2024 at 6:11 AM Jiri Slaby <jirislaby@kernel.org> wrote:
>> On 19. 02. 24, 17:40, Thomas Huth wrote:
>>> Compiling a kernel for the ColdFire causes a compiler warning:
>>>
>>> drivers/tty/serial/mcf.c:473:12: warning: no previous prototype for
>>> ‘early_mcf_setup’ [-Wmissing-prototypes]
>>> 473 | int __init early_mcf_setup(struct mcf_platform_uart *platp)
>>> | ^~~~~~~~~~~~~~~
>>>
>>> This function seems to be completely unused, so let's remove it
>>> to silence the warning.
>>
>> And it seems so since the driver addition in 2007 by:
>> commit 49aa49bfd40d718095669c1c70c9d167b814e29b
>> Author: Greg Ungerer <gerg@snapgear.com>
>> Date: Tue Oct 23 14:37:54 2007 +1000
>>
>> m68knommu: new style ColdFire UART driver
>
> Indeed.
>
> Looks like the "changes to the ColdFire based m68knommu systems
> to use a platform model at init, and this is used there" from [1]
> never materialized on any public mailing list?
>
> Greg: does it still make sense to add them?
No, it never really turned out to be useful enough to anyone,
so I never really pushed it out or progressed it any further.
So I am fine with removing this now:
Acked-by: Greg Ungerer <gerg@linux-m68k.org>
I can take it via the m68knommu git tree if no one else wants to
pick it up.
Regards
Greg
> If not:
> Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
>
> [1] https://lore.kernel.org/all/47254BEB.2040609@snapgear.com/
>
> Gr{oetje,eeting}s,
>
> Geert
>
prev parent reply other threads:[~2024-02-20 13:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-19 16:40 [PATCH] drivers/tty/serial: Remove unused function early_mcf_setup Thomas Huth
2024-02-20 5:11 ` Jiri Slaby
2024-02-20 10:23 ` Geert Uytterhoeven
2024-02-20 13:55 ` Greg Ungerer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=590107ef-16f1-4680-8fd6-11df838ce14a@linux-m68k.org \
--to=gerg@linux-m68k.org \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-serial@vger.kernel.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).