From: Finn Thain <fthain@linux-m68k.org>
To: Michael Schmitz <schmitzmic@gmail.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
will@sowerbutts.com, linux-m68k@vger.kernel.org,
rz@linux-m68k.org,
John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Subject: Re: [PATCH RFC v3 2/2] m68k/q40: add data_swab option for pata_falcon to byte-swap disk data
Date: Tue, 22 Aug 2023 09:18:54 +1000 (AEST) [thread overview]
Message-ID: <3530e493-1cc6-8913-fb97-3abb0c83c76c@linux-m68k.org> (raw)
In-Reply-To: <7fc5e704-d4ba-67d2-88cd-38d8dd2b1dfb@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1812 bytes --]
On Tue, 22 Aug 2023, Michael Schmitz wrote:
> CC Adrian for comment...
>
My comments in the messages quoted below should not be interpreted as an
objection to the patches Michael submitted.
I've already done too much bikeshedding there and while it's always
tempting to do more I will desist.
This was just a look askance at the design of the driver model. So it's
really only of academic interest.
> Does anything in the Debian installer rely on a specific device name suffix in
> /sys/bus/platform/devices/ ?
>
> On Atari, atari-falcon-ide does not have a suffix, but on Q40, it would get
> suffix .0 or .1 depending on what IO base the ISA IDE adapter uses.
>
> Seeing as Q40 support in the atari-falcon-ide has been broken since it was
> introduced, this is rather about future installer support than about
> inadvertently breaking current code.
>
> Cheers,
>
> Michael
>
> On 21/08/23 23:08, Finn Thain wrote:
> > On Mon, 21 Aug 2023, Geert Uytterhoeven wrote:
> >
> >> On Sat, Aug 19, 2023 at 1:53 AM Finn Thain <fthain@linux-m68k.org> wrote:
> >>> On Fri, 18 Aug 2023, Geert Uytterhoeven wrote:
> >>>> Of course 0 also works, but causes ".0" to be appended to the platform
> >>>> device's name, visible in e.g. /sys/bus/platform/devices/.
> >>> That seems desirable to me.
> >> Why would it be desirable?
> >> IMHO this is an unneeded change which is visible in userspace.
> >>
> > Only so what's visible in userspace would be consistent across atari and
> > q40 (and anything else that happens to instantiate the device in future).
> >
> > Basically, I don't really understand why id -1 is better than id 0. I've
> > searched Documentation/device-tree and I still don't understand why a
> > singleton would need a special bus id.
>
next prev parent reply other threads:[~2023-08-21 23:18 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-17 3:49 [PATCH RFC v3 0/2] Q40 IDE fixes Michael Schmitz
2023-08-17 3:50 ` [PATCH RFC v3 1/2] m68k/q40: fix IO base selection for Q40 in pata_falcon.c Michael Schmitz
2023-08-17 3:50 ` [PATCH RFC v3 2/2] m68k/q40: add data_swab option for pata_falcon to byte-swap disk data Michael Schmitz
2023-08-17 10:15 ` Finn Thain
2023-08-17 11:47 ` Geert Uytterhoeven
2023-08-17 19:21 ` Michael Schmitz
2023-08-17 21:28 ` Michael Schmitz
2023-08-18 14:33 ` Geert Uytterhoeven
2023-08-18 23:53 ` Finn Thain
2023-08-21 7:46 ` Geert Uytterhoeven
2023-08-21 11:08 ` Finn Thain
2023-08-21 20:36 ` Michael Schmitz
2023-08-21 23:18 ` Finn Thain [this message]
[not found] ` <F32F62FE-2A74-4648-8BF1-0D1A1E76309B@linux-m68k.org>
2023-08-17 19:07 ` Michael Schmitz
2023-08-17 19:14 ` Michael Schmitz
2023-08-18 0:36 ` Finn Thain
2023-08-17 3:56 ` [PATCH RFC v3 0/2] Q40 IDE fixes Michael Schmitz
2023-08-17 9:20 ` William R Sowerbutts
2023-08-17 20:25 ` William R Sowerbutts
2023-08-17 21:29 ` Michael Schmitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3530e493-1cc6-8913-fb97-3abb0c83c76c@linux-m68k.org \
--to=fthain@linux-m68k.org \
--cc=geert@linux-m68k.org \
--cc=glaubitz@physik.fu-berlin.de \
--cc=linux-m68k@vger.kernel.org \
--cc=rz@linux-m68k.org \
--cc=schmitzmic@gmail.com \
--cc=will@sowerbutts.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).