Linux-m68k Archive mirror
 help / color / mirror / Atom feed
From: Michael Schmitz <schmitzmic@gmail.com>
To: martin.petersen@oracle.com, linux-scsi@vger.kernel.org
Cc: linux-m68k@vger.kernel.org, geert@linux-m68k.org, arnd@arndb.de,
	Michael Schmitz <schmitzmic@gmail.com>
Subject: [PATCH] scsi: gvp11: add module parameter for DMA transfer bit mask
Date: Wed, 30 Aug 2023 09:45:17 +1200	[thread overview]
Message-ID: <20230829214517.14448-1-schmitzmic@gmail.com> (raw)

Commit bfaa4a0ce1bb ("scsi: gvp11: Remove unused gvp11_setup()
function") removed the unused gvp11_setup() which had allowed
to override the default DMA transfer mask defined for GVP II
SCSI boards on Amiga. There now is no way to set a non-default
DMA mask on these boards.

Introduce a module parameter to allow users to override the
default DMA mask for the gvp11 driver.

Fixes: bfaa4a0ce1bb ("scsi: gvp11: Remove unused gvp11_setup() function")
Link: https://lore.kernel.org/r/20230810141947.1236730-12-arnd@kernel.org
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Michael Schmitz <schmitzmic@gmail.com>
---
 drivers/scsi/gvp11.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/scsi/gvp11.c b/drivers/scsi/gvp11.c
index 0420bfe9bd42..12160d70a571 100644
--- a/drivers/scsi/gvp11.c
+++ b/drivers/scsi/gvp11.c
@@ -50,6 +50,9 @@ static irqreturn_t gvp11_intr(int irq, void *data)
 
 static int gvp11_xfer_mask = 0;
 
+module_param(gvp11_xfer_mask,  int, 0444);
+MODULE_PARM_DESC(gvp11_xfer_mask, "DMA mask (0xff000000 == 24 bit DMA)");
+
 static int dma_setup(struct scsi_cmnd *cmd, int dir_in)
 {
 	struct scsi_pointer *scsi_pointer = WD33C93_scsi_pointer(cmd);
-- 
2.17.1


             reply	other threads:[~2023-08-29 21:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-29 21:45 Michael Schmitz [this message]
2023-08-29 22:05 ` [PATCH] scsi: gvp11: add module parameter for DMA transfer bit mask Arnd Bergmann
2023-08-29 22:25   ` Michael Schmitz
2023-08-30  0:14     ` Arnd Bergmann
2023-08-30  0:47       ` Michael Schmitz
2023-08-30  7:32     ` Geert Uytterhoeven
2023-08-30  7:52       ` Michael Schmitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230829214517.14448-1-schmitzmic@gmail.com \
    --to=schmitzmic@gmail.com \
    --cc=arnd@arndb.de \
    --cc=geert@linux-m68k.org \
    --cc=linux-m68k@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).