From: "Arnd Bergmann" <arnd@arndb.de>
To: "Lee Jones" <lee@kernel.org>, "Heiner Kallweit" <hkallweit1@gmail.com>
Cc: "Pavel Machek" <pavel@ucw.cz>, "Andrew Lunn" <andrew@lunn.ch>,
"linux-leds@vger.kernel.org" <linux-leds@vger.kernel.org>
Subject: Re: [PATCH] leds: Change devm_led_classdev_register_ext stub logic to use IS_REACHABLE
Date: Tue, 09 Jan 2024 10:04:35 +0100 [thread overview]
Message-ID: <c6cd1b86-d468-4123-beaa-575206dc3555@app.fastmail.com> (raw)
In-Reply-To: <20240109083739.GE7948@google.com>
On Tue, Jan 9, 2024, at 09:37, Lee Jones wrote:
> On Thu, 28 Dec 2023, Heiner Kallweit wrote:
>
>> If CONFIG_LEDS_CLASS = m and the caller of devm_led_classdev_register
>> is built-in, we get a compile/link error.
>> To avoid this we could add conditional compiling to the caller, but
>> exactly this overhead we wanted to avoid with adding the stubs.
>> Easiest solution is to use the existing stub also in case IS_ENABLED
>> is true, but IS_REACHABLE is false.
>>
>> Fixes: 18764b883e15 ("r8169: add support for LED's on RTL8168/RTL8101")
>> Reported-by: kernel test robot <lkp@intel.com>
>> Closes: https://lore.kernel.org/oe-kbuild-all/202312281159.9TPeXbNd-lkp@intel.com/
>> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
>> ---
>> include/linux/leds.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Arnd pretty much NACKed this, right?
>
> https://lore.kernel.org/r/b310230b-f20b-489a-97ed-908df193a942@app.fastmail.com
Yes, I actually wrote a replacement that does the opposite,
I just need to send that out.
Arnd
prev parent reply other threads:[~2024-01-09 9:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-28 8:55 [PATCH] leds: Change devm_led_classdev_register_ext stub logic to use IS_REACHABLE Heiner Kallweit
2024-01-09 8:37 ` Lee Jones
2024-01-09 9:04 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c6cd1b86-d468-4123-beaa-575206dc3555@app.fastmail.com \
--to=arnd@arndb.de \
--cc=andrew@lunn.ch \
--cc=hkallweit1@gmail.com \
--cc=lee@kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).