From: andy.shevchenko@gmail.com
To: Xing Tong Wu <xingtong_wu@163.com>
Cc: lee@kernel.org, Pavel Machek <pavel@ucw.cz>,
Hans de Goede <hdegoede@redhat.com>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
Gerd Haeussler <gerd.haeussler.ext@siemens.com>,
Xing Tong Wu <xingtong.wu@siemens.com>,
Tobias Schaffner <tobias.schaffner@siemens.com>,
Henning Schild <henning@hennsch.de>
Subject: Re: [RESEND PATCH v2 1/1] leds: simatic-ipc-leds-gpio: add support for module BX-59A
Date: Thu, 22 Feb 2024 23:40:27 +0200 [thread overview]
Message-ID: <Zde_S6X8OdEDyxDy@surfacebook.localdomain> (raw)
In-Reply-To: <20240218062806.3932-2-xingtong_wu@163.com>
Sun, Feb 18, 2024 at 02:28:06PM +0800, Xing Tong Wu kirjoitti:
> From: Xing Tong Wu <xingtong.wu@siemens.com>
>
> This is used for the Siemens Simatic IPC BX-59A, which has its LEDs
> connected to GPIOs provided by the Nuvoton NCT6126D
MIssing period at the end of the sentence.
...
> static int simatic_ipc_leds_gpio_f7188x_probe(struct platform_device *pdev)
> {
> + const struct simatic_ipc_platform *plat = pdev->dev.platform_data;
dev_get_platdata()
> + struct simatic_ipc_led_tables *led_tables;
> +
> + led_tables = devm_kzalloc(&pdev->dev, sizeof(*led_tables), GFP_KERNEL);
> + if (!led_tables)
> + return -ENOMEM;
> +
> + switch (plat->devmode) {
> + case SIMATIC_IPC_DEVICE_227G:
> + led_tables->led_lookup_table = &simatic_ipc_led_gpio_table_227g;
> + led_tables->led_lookup_table_extra = &simatic_ipc_led_gpio_table_extra_227g;
> + break;
> + case SIMATIC_IPC_DEVICE_BX_59A:
> + led_tables->led_lookup_table = &simatic_ipc_led_gpio_table_bx_59a;
> + break;
> + default:
> + return -ENODEV;
> + }
> +
> + dev_set_drvdata(&pdev->dev, led_tables);
platform_set_drvdata()
> + return simatic_ipc_leds_gpio_probe(pdev, led_tables->led_lookup_table,
> + led_tables->led_lookup_table_extra);
> }
...
> static void simatic_ipc_leds_gpio_f7188x_remove(struct platform_device *pdev)
> {
> + struct simatic_ipc_led_tables *led_tables;
> + led_tables = dev_get_drvdata(&pdev->dev);
platform_get_drvdata()
> + simatic_ipc_leds_gpio_remove(pdev, led_tables->led_lookup_table,
> + led_tables->led_lookup_table_extra);
> }
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2024-02-22 21:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-04 8:30 [PATCH RESEND 0/1] Patch Resent: Enabling LED Support for Siemens IPC BX-59A Xing Tong Wu
2024-02-04 8:30 ` [PATCH RESEND 1/1] leds: simatic-ipc-leds-gpio: add support for module BX-59A Xing Tong Wu
2024-02-08 12:09 ` Lee Jones
2024-02-18 6:28 ` [RESEND PATCH v2 0/1] Patch Resent: Enabling LED Support for Siemens IPC BX-59A Xing Tong Wu
2024-02-18 6:28 ` [RESEND PATCH v2 1/1] leds: simatic-ipc-leds-gpio: add support for module BX-59A Xing Tong Wu
2024-02-22 21:40 ` andy.shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zde_S6X8OdEDyxDy@surfacebook.localdomain \
--to=andy.shevchenko@gmail.com \
--cc=gerd.haeussler.ext@siemens.com \
--cc=hdegoede@redhat.com \
--cc=henning@hennsch.de \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=tobias.schaffner@siemens.com \
--cc=xingtong.wu@siemens.com \
--cc=xingtong_wu@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).