From: Lee Jones <lee@kernel.org>
To: Abdel Alkuor <alkuor@gmail.com>
Cc: "Pavel Machek" <pavel@ucw.cz>, "Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Lukas Bulwahn" <lukas.bulwahn@gmail.com>,
"Jean-Jacques Hiblot" <jjhiblot@traphandler.com>,
"ChiYuan Huang" <cy_huang@richtek.com>,
"André Apitzsch" <git@apitzsch.eu>,
"Alice Chen" <alice_chen@richtek.com>,
"Jacek Anaszewski" <jacek.anaszewski@gmail.com>,
"ChiaEn Wu" <chiaen_wu@richtek.com>,
linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 2/2] leds: Add NCP5623 multi-led driver
Date: Fri, 23 Feb 2024 16:20:42 +0000 [thread overview]
Message-ID: <20240223162042.GJ1666215@google.com> (raw)
In-Reply-To: <Zci9xE5uHRJGMg5q@primary>
On Sun, 11 Feb 2024, Abdel Alkuor wrote:
> On Thu, Feb 08, 2024 at 01:01:15PM +0000, Lee Jones wrote:
> > On Sat, 03 Feb 2024, Abdel Alkuor wrote:
> >
> Hi Lee,
>
> Please check the inline comment. All other comments will be addressed
> in v2.
>
> > > +What: /sys/class/leds/<led>/dim_step
> >
> > The step principle seems a bit arbitrary.
> >
> > Why not provide the time directly?
> >
> > dim_step_delay?
> >
> > I already see documentation for risetime and falltime.
> >
> > Perhaps that will omit the need for both direction and step?
> >
> I'm going to drop off both and use risetime and falltime. That being
> said, the documented risetime and falltime for lm3533 use steps instead of
> entering the time directly. This is my first time doing this, should I document
> risetime/falltime in sysfs-class-led-multicolor-driver-ncp5623? or should
> I update risetime/falltime in sysfs-class-led-driver-lm3533 to reflect
> risetime/falltime for ncp5623?
Keep them separate please.
> > > +Date: Feb 2024
> > > +KernelVersion: 6.8
> > > +Contact: Abdel Alkuor <alkuor@gmail.com>
> > > +Description:
> > > + Set gradual dimming time.
> > > +
> > > + ==== ======== ==== ======== ==== ========
> > > + Step Time(ms) Step Time(ms) Step Time(ms)
> > > + 0 0 11 88 22 176
> > > + 1 8 12 96 23 184
> > > + 2 16 13 104 24 192
> > > + 3 24 14 112 25 200
> > > + 4 32 15 120 26 208
> > > + 5 40 16 128 27 216
> > > + 6 48 17 136 28 224
> > > + 7 56 18 144 29 232
> > > + 8 64 19 152 30 240
> > > + 9 72 20 160 31 248
> > > + 10 80 21 168
> > > + ==== ======== ==== ======== ==== ========
>
> Thanks,
> Abdel
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2024-02-23 16:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-03 17:58 [PATCH 1/2] dt: bindings: leds: Add NCP5623 multi-LED Controller Abdel Alkuor
2024-02-03 17:58 ` [PATCH 2/2] leds: Add NCP5623 multi-led driver Abdel Alkuor
2024-02-08 13:01 ` Lee Jones
2024-02-11 12:29 ` Abdel Alkuor
2024-02-23 16:20 ` Lee Jones [this message]
2024-02-13 9:18 ` Pavel Machek
2024-02-17 21:49 ` Abdel Alkuor
2024-02-05 8:39 ` [PATCH 1/2] dt: bindings: leds: Add NCP5623 multi-LED Controller Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240223162042.GJ1666215@google.com \
--to=lee@kernel.org \
--cc=alice_chen@richtek.com \
--cc=alkuor@gmail.com \
--cc=chiaen_wu@richtek.com \
--cc=conor+dt@kernel.org \
--cc=cy_huang@richtek.com \
--cc=devicetree@vger.kernel.org \
--cc=git@apitzsch.eu \
--cc=jacek.anaszewski@gmail.com \
--cc=jjhiblot@traphandler.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).