From: Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com>
To: linux-pci@vger.kernel.org, linux-leds@vger.kernel.org
Cc: Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com>,
Arnd Bergmann <arnd@arndb.de>,
Bjorn Helgaas <bhelgaas@google.com>,
Dan Williams <dan.j.williams@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Ilpo Jarvinen <ilpo.jarvinen@linux.intel.com>,
Lukas Wunner <lukas@wunner.de>, Keith Busch <kbusch@kernel.org>,
Marek Behun <marek.behun@nic.cz>, Pavel Machek <pavel@ucw.cz>,
Randy Dunlap <rdunlap@infradead.org>,
Shevchenko, Andriy <andriy.shevchenko@intel.com>,
Stuart Hayes <stuart.w.hayes@gmail.com>
Subject: [PATCH 0/2] Native PCIe Enclosure Management
Date: Thu, 15 Feb 2024 15:23:43 +0100 [thread overview]
Message-ID: <20240215142345.6073-1-mariusz.tkaczyk@linux.intel.com> (raw)
In this patchset support of Native PCIe Enclosure Management is proposed.
Stuart Hayes was working on this earlier. It is a new serie because it
is NPEM only.
NPEM is pattern oriented standard, it tells which "pattern" should blink.
It doesn't control physical LED or pattern visualization. It is described
better in second patch.
Overall, driver is simple but it was not simple to fit it into interfaces
we have in kernel (We considered leds and enclosure interfaces). It reuses
leds interface, this approach seems to be the best because:
- leds are actively maintained, no new interface added.
- leds do not require any extensions, enclosure needs to be adjusted first.
There are trade-offs:
- "brightness" is the name of sysfs file to control led. It is not
natural to use brightness to set patterns, that is why multiple led
devices are created (one per pattern);
- Update of one led may affect other leds, led triggers may not work
as expected.
It doesn't provide ACPI _DSM support, it requires separate implementation
outside drives/pci/ but NPEM is not registered if _DSM is available.
This patchset was made in close collaboration with Lucas Wunner.
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Ilpo Jarvinen <ilpo.jarvinen@linux.intel.com>
Cc: Lukas Wunner <lukas@wunner.de>
Cc: Keith Busch <kbusch@kernel.org>
Cc: Marek Behun <marek.behun@nic.cz>
Cc: Pavel Machek <pavel@ucw.cz>
Cc: Randy Dunlap <rdunlap@infradead.org>
Cc: Shevchenko, Andriy <andriy.shevchenko@intel.com>
Cc: Stuart Hayes <stuart.w.hayes@gmail.com>
Link: https://lore.kernel.org/linux-pci/20201106194221.59353-1-stuart.w.hayes@gmail.com/
Link: https://lore.kernel.org/linux-pci/20201110153735.58587-1-stuart.w.hayes@gmail.com/
Link: https://lore.kernel.org/linux-pci/20210416192010.3197-1-stuart.w.hayes@gmail.com/
Link: https://lore.kernel.org/linux-pci/20210601203820.3647-1-stuart.w.hayes@gmail.com/
Link: https://lore.kernel.org/linux-pci/20210813213653.3760-1-stuart.w.hayes@gmail.com/
Link: https://lore.kernel.org/linux-pci/cover.1642460765.git.stuart.w.hayes@gmail.com/
Link: https://lore.kernel.org/linux-pci/cover.1643822289.git.stuart.w.hayes@gmail.com/
Mariusz Tkaczyk (2):
leds: Init leds class earlier
PCI/NPEM: Add Native PCIe Enclosure Management support
drivers/leds/led-class.c | 2 +-
drivers/pci/Kconfig | 7 +
drivers/pci/Makefile | 1 +
drivers/pci/bus.c | 1 +
drivers/pci/npem.c | 339 ++++++++++++++++++++++++++++++++++
drivers/pci/pci.h | 8 +
drivers/pci/remove.c | 1 +
include/linux/pci.h | 4 +
include/uapi/linux/pci_regs.h | 34 ++++
9 files changed, 396 insertions(+), 1 deletion(-)
create mode 100644 drivers/pci/npem.c
--
2.35.3
next reply other threads:[~2024-02-15 14:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-15 14:23 Mariusz Tkaczyk [this message]
2024-02-15 14:23 ` [PATCH 1/2] leds: Init leds class earlier Mariusz Tkaczyk
2024-02-15 14:23 ` [PATCH 2/2] PCI/NPEM: Add Native PCIe Enclosure Management support Mariusz Tkaczyk
2024-03-06 22:40 ` Bjorn Helgaas
2024-03-07 12:25 ` Lukas Wunner
2024-03-11 9:47 ` Mariusz Tkaczyk
2024-03-11 22:13 ` Bjorn Helgaas
[not found] ` <CAL5oW00nSZV=oAjWPbYTwVGZ9OS1hW9hyZ5C0yzWbMjAstAA2g@mail.gmail.com>
2024-03-12 9:08 ` Mariusz Tkaczyk
2024-03-22 19:56 ` Bjorn Helgaas
2024-03-22 21:30 ` Dan Williams
2024-03-22 21:42 ` Bjorn Helgaas
2024-03-22 21:51 ` Dan Williams
2024-03-23 5:09 ` Lukas Wunner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240215142345.6073-1-mariusz.tkaczyk@linux.intel.com \
--to=mariusz.tkaczyk@linux.intel.com \
--cc=andriy.shevchenko@intel.com \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=dan.j.williams@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=kbusch@kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=marek.behun@nic.cz \
--cc=pavel@ucw.cz \
--cc=rdunlap@infradead.org \
--cc=stuart.w.hayes@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).