From: Lee Jones <lee@kernel.org>
To: Pavel Machek <pavel@ucw.cz>, Lee Jones <lee@kernel.org>,
Martin Kurbanov <mmkurbanov@salutedevices.com>
Cc: linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org,
kernel@salutedevices.com
Subject: Re: (subset) [PATCH v2 RESEND] leds: trigger: pattern: add support for hrtimer
Date: Thu, 02 May 2024 17:32:19 +0100 [thread overview]
Message-ID: <171466753939.1199434.16328391643586401261.b4-ty@kernel.org> (raw)
In-Reply-To: <20240416201847.357099-1-mmkurbanov@salutedevices.com>
On Tue, 16 Apr 2024 23:18:05 +0300, Martin Kurbanov wrote:
> Currently, led pattern trigger uses timer_list to schedule brightness
> changing. As we know from timer_list API [1], it's not accurate to
> milliseconds and depends on HZ granularity.
>
> Example:
> "0 10 0 0 50 10 50 0 100 10 100 0 150 10 150 0 200 10 200 0 250 10 250 0",
> we expect it to be 60ms long, but it can actually be up to ~120ms
> (add ~10ms for each pattern when HZ == 100).
>
> [...]
Applied, thanks!
[1/1] leds: trigger: pattern: add support for hrtimer
commit: aa172ba73948e2152e258ead7e9ddbd806e809b0
--
Lee Jones [李琼斯]
prev parent reply other threads:[~2024-05-02 16:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-16 20:18 [PATCH v2 RESEND] leds: trigger: pattern: add support for hrtimer Martin Kurbanov
2024-05-02 16:32 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171466753939.1199434.16328391643586401261.b4-ty@kernel.org \
--to=lee@kernel.org \
--cc=kernel@salutedevices.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mmkurbanov@salutedevices.com \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).