From: Rob Herring <robh@kernel.org>
To: INAGAKI Hiroshi <musashino.open@gmail.com>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
lee@kernel.org, krzysztof.kozlowski+dt@linaro.org,
linux-leds@vger.kernel.org, pavel@ucw.cz, conor+dt@kernel.org
Subject: Re: [PATCH 2/2] dt-bindings: leds: add LED_FUNCTION_SPEED_* for link speed on LAN/WAN
Date: Fri, 22 Mar 2024 09:54:37 -0500 [thread overview]
Message-ID: <171111927468.885822.4599184890388891198.robh@kernel.org> (raw)
In-Reply-To: <20240320124431.221-3-musashino.open@gmail.com>
On Wed, 20 Mar 2024 21:43:17 +0900, INAGAKI Hiroshi wrote:
> Add LED_FUNCTION_SPEED_LAN and LED_FUNCTION_SPEED_WAN for LEDs that
> indicate link speed of ethernet ports on LAN/WAN. This is useful to
> distinguish those LEDs from LEDs that indicate link status (up/down).
>
> example:
>
> Fortinet FortiGate 30E/50E have LEDs that indicate link speed on each
> of the ethernet ports in addition to LEDs that indicate link status
> (up/down).
>
> - 1000 Mbps: green:speed-(lan|wan)-N
> - 100 Mbps: amber:speed-(lan|wan)-N
> - 10 Mbps: (none, turned off)
>
> Signed-off-by: INAGAKI Hiroshi <musashino.open@gmail.com>
> ---
> include/dt-bindings/leds/common.h | 2 ++
> 1 file changed, 2 insertions(+)
>
Reviewed-by: Rob Herring <robh@kernel.org>
prev parent reply other threads:[~2024-03-22 14:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-20 12:43 [PATCH 0/2] dt-bindings: leds: add LED_FUNCTION_* mainly for router devices INAGAKI Hiroshi
2024-03-20 12:43 ` [PATCH 1/2] dt-bindings: leds: add LED_FUNCTION_MOBILE for mobile network INAGAKI Hiroshi
2024-03-21 13:55 ` Rob Herring
2024-03-21 14:28 ` INAGAKI Hiroshi
2024-03-20 12:43 ` [PATCH 2/2] dt-bindings: leds: add LED_FUNCTION_SPEED_* for link speed on LAN/WAN INAGAKI Hiroshi
2024-03-22 14:54 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171111927468.885822.4599184890388891198.robh@kernel.org \
--to=robh@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=musashino.open@gmail.com \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).