From: Subrata Modak <subrata@linux.vnet.ibm.com>
To: Ingo Molnar <mingo@elte.hu>,
linux-laptop@vger.kernel.org,
Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Sachin P Sant <sachinp@linux.vnet.ibm.com>,
Ingo Molnar <mingo@redhat.com>,
David Howells <dhowells@redhat.com>,
Subrata Modak <subrata@linux.vnet.ibm.com>,
Balbir Singh <balbir@linux.vnet.ibm.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH 05/06][RESEND] Fix compilation warning for arch/x86/kernel/apm_32.c
Date: Tue, 21 Jul 2009 08:02:27 +0530 [thread overview]
Message-ID: <20090721023226.31855.67236.sendpatchset@subratamodak.linux.ibm.com> (raw)
The following fix was initially inspired by David Howells fix few days back:
http://lkml.org/lkml/2009/7/9/109,
However, Ingo disapproves such fixes as it's dangerous - in something as
performance-uncritical. So, initialize 'err' to '0' to work around a GCC false
positive warning:
http://lkml.org/lkml/2009/7/18/89,
Signed-off-by: Subrata Modak<subrata@linux.vnet.ibm.com>
---
--- a/arch/x86/kernel/apm_32.c 2009-06-15 07:50:51.000000000 +0530
+++ b/arch/x86/kernel/apm_32.c 2009-07-15 06:43:59.000000000 +0530
@@ -811,7 +811,7 @@ static int apm_do_idle(void)
u8 ret = 0;
int idled = 0;
int polling;
- int err;
+ int err = 0;
polling = !!(current_thread_info()->status & TS_POLLING);
if (polling) {
---
Regards--
Subrata
reply other threads:[~2009-07-21 2:32 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090721023226.31855.67236.sendpatchset@subratamodak.linux.ibm.com \
--to=subrata@linux.vnet.ibm.com \
--cc=balbir@linux.vnet.ibm.com \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-laptop@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=sachinp@linux.vnet.ibm.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).