From: Ingo Molnar <mingo@elte.hu>
To: Niels de Vos <niels.devos@wincor-nixdorf.com>
Cc: sfr@canb.auug.org.au, linux-laptop@vger.kernel.org,
linux-kernel@vger.kernel.org, Alan Cox <alan@lxorguk.ukuu.org.uk>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] apm: Remove CONFIG_APM_REAL_MODE_POWER_OFF in favor of kernel parameter
Date: Thu, 20 Nov 2008 09:50:43 +0100 [thread overview]
Message-ID: <20081120085043.GK21785@elte.hu> (raw)
In-Reply-To: <4924201B.8010301@wincor-nixdorf.com>
* Niels de Vos <niels.devos@wincor-nixdorf.com> wrote:
> Remove CONFIG_APM_REAL_MODE_POWER_OFF like CONFIG_APM_POWER_OFF
> which has been done for linux-2.2.14pre8
> (http://lkml.org/lkml/1999/11/23/3).
>
> Re-introducing CONFIG_APM_POWER_OFF got nack-ed. Stephen didn't bother
> to remove CONFIG_APM_REAL_MODE_POWER_OFF, let's get rid of it now.
> Reference: http://lkml.org/lkml/2008/5/7/97
>
> Signed-off-by: Niels de Vos <niels.devos@wincor-nixdorf.com>
>
> ---
> arch/x86/Kconfig | 7 -------
> arch/x86/kernel/apm_32.c | 4 ----
> 2 files changed, 0 insertions(+), 11 deletions(-)
>
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index 93224b5..d0b9ef7 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -1629,13 +1629,6 @@ config APM_ALLOW_INTS
> many of the newer IBM Thinkpads. If you experience hangs when you
> suspend, try setting this to Y. Otherwise, say N.
>
> -config APM_REAL_MODE_POWER_OFF
> - bool "Use real mode APM BIOS call to power off"
> - help
> - Use real mode APM BIOS calls to switch off the computer. This is
> - a work-around for a number of buggy BIOSes. Switch this option on if
> - your computer crashes instead of powering off properly.
> -
> -#ifdef CONFIG_APM_REAL_MODE_POWER_OFF
> -static int realmode_power_off = 1;
> -#else
> static int realmode_power_off;
> -#endif
this might be an option for obsolete hardware, but still it has the
potential to help people - and they could depend on it. The proper way
to phase out the Kconfig feature would be to insert an obsoletion
warning that triggers in some form when
CONFIG_APM_REAL_MODE_POWER_OFF=y is enabled, and then remove the
config option in 1-2 years. (and keep the boot option of course)
even better we should have a transparent kernel-parameters framework
that would be a one-stop-shop for _both_ .config and boot-time flags.
Something like:
define_bootparam("realmode_power_off");
plus a way to define the help text - all in a single file and in a
single place.
Which would automatically be turned into a kconfig option, a boot
option and (optionally) a sysctl as well, during the kernel build.
We do have the CONFIG_CMDLINE facility in the latest kernels to inject
arbitrary boot parameters during the kernel build, but that does not
have any semantic dimensions and its opacity makes it fragile: there's
no facility that warns if an option is typoed, if an option goes away
or gets changed, there's no help text like we have when there's a
Kconfig entry, etc.
Ingo
prev parent reply other threads:[~2008-11-20 8:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-19 14:18 [PATCH] apm: Remove CONFIG_APM_REAL_MODE_POWER_OFF in favor of kernel parameter Niels de Vos
2008-11-20 8:50 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081120085043.GK21785@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-laptop@vger.kernel.org \
--cc=niels.devos@wincor-nixdorf.com \
--cc=sfr@canb.auug.org.au \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).