From: Subrata Modak <subrata@linux.vnet.ibm.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: linux-laptop@vger.kernel.org,
Stephen Rothwell <sfr@canb.auug.org.au>,
Sachin P Sant <sachinp@linux.vnet.ibm.com>,
Ingo Molnar <mingo@redhat.com>,
David Howells <dhowells@redhat.com>,
Balbir Singh <balbir@linux.vnet.ibm.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 05/06] Fix compilation warning for arch/x86/kernel/apm_32.c
Date: Tue, 21 Jul 2009 08:03:55 +0530 [thread overview]
Message-ID: <1248143636.9140.4.camel@subratamodak.linux.ibm.com> (raw)
In-Reply-To: <20090718141322.GI32618@elte.hu>
On Sat, 2009-07-18 at 16:13 +0200, Ingo Molnar wrote:
> * Subrata Modak <subrata@linux.vnet.ibm.com> wrote:
>
> > Following fix is inspired by David Howells fix few days back:
> > http://lkml.org/lkml/2009/7/9/109,
> >
> > Signed-off-by: Subrata Modak<subrata@linux.vnet.ibm.com>,
> > ---
> >
> > --- a/arch/x86/kernel/apm_32.c 2009-06-15 07:50:51.000000000 +0530
> > +++ b/arch/x86/kernel/apm_32.c 2009-07-15 06:43:59.000000000 +0530
> > @@ -811,7 +811,7 @@ static int apm_do_idle(void)
> > u8 ret = 0;
> > int idled = 0;
> > int polling;
> > - int err;
> > + int uninitialized_var(err);
>
> Please dont use uninitialized_var() as it's dangerous - in something
> as performance-uncritical as this we should initialize it to 0 and
> mention it in the changelog that this works around a GCC false
> positive warning.
Sure. Resending as you suggested.
Regards--
Subrata
>
> Thanks,
>
> Ingo
prev parent reply other threads:[~2009-07-21 2:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-15 2:20 [PATCH 05/06] Fix compilation warning for arch/x86/kernel/apm_32.c Subrata Modak
2009-07-18 14:13 ` Ingo Molnar
2009-07-21 2:33 ` Subrata Modak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1248143636.9140.4.camel@subratamodak.linux.ibm.com \
--to=subrata@linux.vnet.ibm.com \
--cc=balbir@linux.vnet.ibm.com \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-laptop@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=sachinp@linux.vnet.ibm.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).