From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Linas Vepstas <linas@austin.ibm.com>
Cc: sfr@canb.auug.org.au,
Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>,
long <tlnguyen@snoqualmie.dp.intel.com>, Greg KH <greg@kroah.com>,
linux-laptop@vger.kernel.org, linux-kernel@vger.kernel.org,
Andi Kleen <ak@muc.de>,
pavel@suse.cz, Paul Mackerras <paulus@samba.org>,
linuxppc64-dev <linuxppc64-dev@ozlabs.org>,
linux-pci@atrey.karlin.mff.cuni.cz, johnrose@us.ibm.com,
mochel@transmeta.com
Subject: Re: PCI Power management (was: Re: [PATCH 4/13]: PCI Err: e100 ethernet driver recovery
Date: Fri, 01 Jul 2005 09:32:43 +1000 [thread overview]
Message-ID: <1120174364.31924.57.camel@gaston> (raw)
In-Reply-To: <20050630203931.GY28499@austin.ibm.com>
On Thu, 2005-06-30 at 15:39 -0500, Linas Vepstas wrote:
> Thus, the right thing to do might be to split up the
> struct pci_dev->suspend() and pci_dev->resume() calls into
>
> suspend()
> poweroff()
> poweron()
> resume()
No. There are very good reasons not to do that split at the pci_dev
level.
> and then have the generic pci error recovery routines call
> suspend/resume only, skipping the poweroff-on calls. Does that
> sound good?
>
> I'm not sure I can pull this off without having someone from
> the power-management world throw a brick at me.
Just keep the error recovery callbacks for now, and we might be able to
provide a generic "helper" doing the watchdog thing (yes, there is a
watchdog in the net core)
Ben.
prev parent reply other threads:[~2005-06-30 23:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20050628235848.GA6376@austin.ibm.com>
[not found] ` <1120009619.5133.228.camel@gaston>
[not found] ` <20050629155954.GH28499@austin.ibm.com>
[not found] ` <20050629165828.GA73550@muc.de>
2005-06-30 20:39 ` PCI Power management (was: Re: [PATCH 4/13]: PCI Err: e100 ethernet driver recovery Linas Vepstas
2005-06-30 21:07 ` Linas Vepstas
2005-06-30 23:32 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1120174364.31924.57.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=ak@muc.de \
--cc=greg@kroah.com \
--cc=johnrose@us.ibm.com \
--cc=linas@austin.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-laptop@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=linuxppc64-dev@ozlabs.org \
--cc=mochel@transmeta.com \
--cc=paulus@samba.org \
--cc=pavel@suse.cz \
--cc=seto.hidetoshi@jp.fujitsu.com \
--cc=sfr@canb.auug.org.au \
--cc=tlnguyen@snoqualmie.dp.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).