From: Thomas Hood <jdthood@aglu.demon.nl>
To: linux-laptop@vger.kernel.org
Cc: sfr@canb.auug.org.au
Subject: [FIX] apm.c: ignore_normal_resume is set to 1 a bit too late
Date: Sat, 28 May 2005 00:45:32 +0200 [thread overview]
Message-ID: <1117233933.13528.295.camel@thanatos> (raw)
This message contains a fix for a bug in the apm driver.
A bug report was submitted to the Debian BTS saying that on the
submitter's system the apmd proxy script was being run twice on resume.
Having seen exactly the same problem some years ago and knowing that the
solution then was to ensure that the ignore_normal_resume flag got set
before there was any chance of an APM RESUME event being processed, I
checked the current apm.c and I found that ignore_normal_resume was once
again being set too late. I asked the submitter to move the line where
the flag was set and he reported that this change solved the problem. I
append the message in question. The line numbers I mention there are
for Linux 2.6.11.
Please make the indicated change to the apm driver.
-------- Forwarded Message --------
jdthood@aglu.demon.nl wrote to the submitter of Debian bug #310865:
> In arch/i386/kernel/apm.c there is at approximately line 1229:
>
> ignore_normal_resume = 1;
>
> Move this up so that it occurs right after line 1222:
>
> err = set_system_power_state(APM_STATE_SUSPEND);
>
> Let us know if that helps.
It does. Very nice.
I don't understand what I did and how it works. Will you try to
push that into kernel sources or is this no permanent fix?
--
Thomas Hood <jdthood@aglu.demon.nl>
next reply other threads:[~2005-05-27 22:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-27 22:45 Thomas Hood [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-06-05 21:24 [FIX] apm.c: ignore_normal_resume is set to 1 a bit too late Thomas Hood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1117233933.13528.295.camel@thanatos \
--to=jdthood@aglu.demon.nl \
--cc=linux-laptop@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).