From: John Hubbard <jhubbard@nvidia.com>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Reinette Chatre" <reinette.chatre@intel.com>
Cc: Shuah Khan <shuah@kernel.org>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
Fenghua Yu <fenghua.yu@intel.com>,
Valentin Obst <kernel@valentinobst.de>,
linux-kselftest@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
llvm@lists.linux.dev
Subject: Re: [PATCH v2] selftests/resctrl: fix clang build warnings related to abs(), labs() calls
Date: Wed, 8 May 2024 10:29:53 -0700 [thread overview]
Message-ID: <f4d66d0b-ac3a-416b-ad47-3869e84a03fd@nvidia.com> (raw)
In-Reply-To: <7d4d8a31-00db-c7ba-aa8f-0483c8d93700@linux.intel.com>
On 5/8/24 1:00 AM, Ilpo Järvinen wrote:
> On Tue, 7 May 2024, Reinette Chatre wrote:
>
>> Hi John,
>>
>> On 5/7/2024 6:25 PM, John Hubbard wrote:
>>> On 5/7/24 6:21 PM, Reinette Chatre wrote:
>>>> Hi John,
>>> ...
> Yes, there are two *abs() calls in this function.
>
> In this case is okay to remove the first one since it didn't remove
> absolute value completely, whereas in the MBA/MBM cases v1 removed *abs()
> call entirely which was wrong thing to do.
>
> I explicitly noted in my v1 comment that this CMT change is okay but the
> other two were not.
>
Got it, thanks Ilpo (and Reinette), I'll send a v3 with it fixed up
accordingly, appreciate your patience here. :)
thanks,
--
John Hubbard
NVIDIA
prev parent reply other threads:[~2024-05-08 17:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-03 23:40 [PATCH v2] selftests/resctrl: fix clang build warnings related to abs(), labs() calls John Hubbard
2024-05-07 22:30 ` Reinette Chatre
2024-05-08 1:16 ` John Hubbard
2024-05-08 1:21 ` Reinette Chatre
2024-05-08 1:25 ` John Hubbard
2024-05-08 1:37 ` Reinette Chatre
2024-05-08 8:00 ` Ilpo Järvinen
2024-05-08 17:29 ` John Hubbard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4d66d0b-ac3a-416b-ad47-3869e84a03fd@nvidia.com \
--to=jhubbard@nvidia.com \
--cc=fenghua.yu@intel.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=justinstitt@google.com \
--cc=kernel@valentinobst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=reinette.chatre@intel.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).