From: John Hubbard <jhubbard@nvidia.com>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: Shuah Khan <shuah@kernel.org>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
Fenghua Yu <fenghua.yu@intel.com>,
Reinette Chatre <reinette.chatre@intel.com>,
Valentin Obst <kernel@valentinobst.de>,
linux-kselftest@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
llvm@lists.linux.dev
Subject: Re: [PATCH] selftests/resctrl: fix clang build warnings related to abs(), labs() calls
Date: Fri, 10 May 2024 11:01:09 -0700 [thread overview]
Message-ID: <e366b4d3-1cf3-48cf-8445-cdbc1156d32b@nvidia.com> (raw)
In-Reply-To: <c1e834d6-266d-d8bb-4e85-cdc440ddcb31@linux.intel.com>
On 5/10/24 2:06 AM, Ilpo Järvinen wrote:
> On Wed, 8 May 2024, John Hubbard wrote:
>
>> When building with clang, via:
>>
>> make LLVM=1 -C tools/testing/selftests
>>
>> ...two types of warnings occur:
>>
>> warning: absolute value function 'abs' given an argument of type
>> 'long' but has parameter of type 'int' which may cause truncation of
>> value
>>
>> warning: taking the absolute value of unsigned type 'unsigned long'
>> has no effect
>>
>> Fix these by:
>>
>> a) using labs() in place of abs(), when long integers are involved, and
>>
>> b) Change to use signed integer data types, in places where subtraction
>> is used (and could end up with negative values).
>>
>> c) Remove a duplicate abs() call in cmt_test.c.
>
> In general, instead of filename, it's better to refer to the actual
> function in this kind of description. And in this particular case,
> cmt_test.c could be replaced with "the CMT selftest" which is more
> descriptive and still unambiguous.
Sure, I'll change that.
>
>> Cc: Reinette Chatre <reinette.chatre@intel.com>
>> Cc: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
>> Signed-off-by: John Hubbard <jhubbard@nvidia.com>
>
> Thank you.
>
> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
>
Thanks for the review!
thanks,
--
John Hubbard
NVIDIA
next prev parent reply other threads:[~2024-05-10 18:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-08 19:02 [PATCH] selftests/resctrl: fix clang build warnings related to abs(), labs() calls John Hubbard
2024-05-08 19:39 ` John Hubbard
2024-05-10 9:06 ` Ilpo Järvinen
2024-05-10 18:01 ` John Hubbard [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-05-03 2:32 John Hubbard
2024-05-03 8:00 ` Ilpo Järvinen
2024-05-03 16:52 ` John Hubbard
2024-05-03 18:37 ` Reinette Chatre
2024-05-03 19:12 ` John Hubbard
2024-05-03 20:46 ` Reinette Chatre
2024-05-03 22:00 ` John Hubbard
2024-05-06 9:07 ` Ilpo Järvinen
2024-05-06 17:21 ` John Hubbard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e366b4d3-1cf3-48cf-8445-cdbc1156d32b@nvidia.com \
--to=jhubbard@nvidia.com \
--cc=fenghua.yu@intel.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=justinstitt@google.com \
--cc=kernel@valentinobst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=reinette.chatre@intel.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).