From: Shuah Khan <skhan@linuxfoundation.org>
To: Shengyu Li <shengyu.li.evgeny@gmail.com>,
shuah@kernel.org, msekleta@redhat.com,
gregkh@linuxfoundation.org, broonie@kernel.org
Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH v2] selftest/tty: Use harness framework in tty
Date: Fri, 3 May 2024 13:43:26 -0600 [thread overview]
Message-ID: <a4e28fb2-6dc2-49f5-831f-95c9fc60570b@linuxfoundation.org> (raw)
In-Reply-To: <20240430161807.96050-1-shengyu.li.evgeny@gmail.com>
On 4/30/24 10:18, Shengyu Li wrote:
> Similarly, this one is based on automated tools and a very
> small percentage of manual modifications to automatically refactor
> the version that uses kselftest_harness.h, which is logically clearer.
>
> Signed-off-by: Shengyu Li <shengyu.li.evgeny@gmail.com>
> ---
>
> v2: Fixed the last Assert
See feedback on your v1. Same comments apply here.
Explain why this refactor is necessary.
thanks,
-- Shuah
prev parent reply other threads:[~2024-05-03 19:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-30 16:18 [PATCH v2] selftest/tty: Use harness framework in tty Shengyu Li
2024-05-03 19:43 ` Shuah Khan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4e28fb2-6dc2-49f5-831f-95c9fc60570b@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=msekleta@redhat.com \
--cc=shengyu.li.evgeny@gmail.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).