From: Sean Christopherson <seanjc@google.com>
To: Sean Christopherson <seanjc@google.com>,
linux-kselftest@vger.kernel.org, Zide Chen <zide.chen@intel.com>
Cc: pbonzini@redhat.com, Dongsheng Zhang <dongsheng.x.zhang@intel.com>
Subject: Re: [PATCH V5] KVM: selftests: Add a new option to rseq_test
Date: Fri, 3 May 2024 14:32:28 -0700 [thread overview]
Message-ID: <171469160565.1008873.16336312098515318304.b4-ty@google.com> (raw)
In-Reply-To: <20240502213936.27619-1-zide.chen@intel.com>
On Thu, 02 May 2024 14:39:36 -0700, Zide Chen wrote:
> Currently, the migration worker delays 1-10 us, assuming that one
> KVM_RUN iteration only takes a few microseconds. But if the CPU low
> power wakeup latency is large enough, for example, hundreds or even
> thousands of microseconds deep C-state exit latencies on x86 server
> CPUs, it may happen that it's not able to wakeup the target CPU before
> the migration worker starts to migrate the vCPU thread to the next CPU.
>
> [...]
Applied to kvm-x86 selftests, thanks! I tweaked the changelog slightly to call
out the new comment and assert message. I also added an extra newline so that
the "help" part of the assert message is isolated from the primary explanation
of why the assert fired. E.g. the output looks like:
==== Test Assertion Failure ====
rseq_test.c:290: skip_sanity_check || i > (NR_TASK_MIGRATIONS * 2002)
pid=20283 tid=20283 errno=4 - Interrupted system call
1 0x000000000040210a: main at rseq_test.c:286
2 0x00007f07fa821c86: ?? ??:0
3 0x0000000000402209: _start at ??:?
Only performed 11162 KVM_RUNs, task stalled too much?
Try disabling deep sleep states to reduce CPU wakeup latency,
e.g. via cpuidle.off=1 or setting /dev/cpu_dma_latency to '0',
or run with -u to disable this sanity check.
[1/1] KVM: selftests: Add a new option to rseq_test
https://github.com/kvm-x86/linux/commit/20ecf595b513
--
https://github.com/kvm-x86/linux/tree/next
prev parent reply other threads:[~2024-05-03 21:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-02 21:39 [PATCH V5] KVM: selftests: Add a new option to rseq_test Zide Chen
2024-05-03 21:32 ` Sean Christopherson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171469160565.1008873.16336312098515318304.b4-ty@google.com \
--to=seanjc@google.com \
--cc=dongsheng.x.zhang@intel.com \
--cc=linux-kselftest@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=zide.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).