From: Abhinav Singh <singhabhinav9051571833@gmail.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: akpm@linux-foundation.org, brauner@kernel.org, surenb@google.com,
mst@redhat.com, michael.christie@oracle.com, mjguzik@gmail.com,
mathieu.desnoyers@efficios.com, npiggin@gmail.com,
linux-kernel@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH v4] Fixing directly deferencing a __rcu pointer warning
Date: Mon, 13 Nov 2023 01:48:14 +0530 [thread overview]
Message-ID: <b6476b5d-5938-45e8-9c3b-14448a5d854f@gmail.com> (raw)
In-Reply-To: <20231112195839.GA9987@noisy.programming.kicks-ass.net>
On 11/13/23 01:28, Peter Zijlstra wrote:
> On Mon, Nov 13, 2023 at 01:00:55AM +0530, Abhinav Singh wrote:
>> This patch fixes the sparse warning with this message
>> "dereference of noderef expression" , in this context
>> it means about directly dereferencing a pointer tagged
>> with __rcu annotation.
>
> Please, stop this madness. Just accept that sparse is a stupid tool and
> the code is actually fine.
Thank you for your tine maintainers. Okay I understood that this extra
patch, is not required. Just one follow up question, in some driver code
as well I see these warning, might be possible those are real issue.
Can you suggest me like how do I know if a rcu related warning is really
a issue or just a false positive warning.
Thanks,
Abhinav.
prev parent reply other threads:[~2023-11-12 20:18 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-25 22:28 [PATCH] Fixing warning of directly dereferencing __rcu tagged Abhinav Singh
2023-10-25 22:38 ` Andrew Morton
2023-10-25 23:27 ` Abhinav Singh
2023-10-25 23:50 ` Andrew Morton
2023-10-26 12:16 ` [PATCH v2] Fixing directly deferencing a __rcu pointer warning Abhinav Singh
2023-10-26 13:14 ` Michael S. Tsirkin
2023-10-26 14:06 ` Mateusz Guzik
2023-10-26 14:51 ` Mathieu Desnoyers
2023-10-26 15:07 ` Mateusz Guzik
2023-10-26 15:17 ` Michael S. Tsirkin
2023-10-26 15:37 ` Abhinav Singh
2023-10-26 15:47 ` Michael S. Tsirkin
2023-10-27 6:37 ` [PATCH v3] " Abhinav Singh
2023-10-27 6:41 ` Abhinav Singh
2023-10-27 7:00 ` Michael S. Tsirkin
2023-10-27 6:50 ` Michael S. Tsirkin
2023-10-26 12:18 ` [PATCH] Fixing warning of directly dereferencing __rcu tagged Abhinav Singh
2023-10-26 12:27 ` [PATCH] Fixing directly deferencing a __rcu pointer warning Abhinav Singh
2023-10-26 15:03 ` Peter Zijlstra
2023-10-27 12:22 ` Oleg Nesterov
2023-10-28 10:22 ` [PATCH v3] " Abhinav Singh
2023-10-28 10:31 ` Abhinav Singh
2023-10-28 12:20 ` Michael S. Tsirkin
2023-10-28 20:43 ` Abhinav Singh
2023-10-28 20:46 ` Abhinav Singh
2023-11-03 6:30 ` kernel test robot
2023-11-12 19:30 ` [PATCH v4] " Abhinav Singh
2023-11-12 19:56 ` Mathieu Desnoyers
2023-11-12 19:58 ` Peter Zijlstra
2023-11-12 20:18 ` Abhinav Singh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6476b5d-5938-45e8-9c3b-14448a5d854f@gmail.com \
--to=singhabhinav9051571833@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=brauner@kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=michael.christie@oracle.com \
--cc=mjguzik@gmail.com \
--cc=mst@redhat.com \
--cc=npiggin@gmail.com \
--cc=peterz@infradead.org \
--cc=surenb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).