From: Matthew Wilcox <willy@infradead.org>
To: Dave Kleikamp <dave.kleikamp@oracle.com>
Cc: Manas Ghandat <ghandatmanas@gmail.com>,
Linux-kernel-mentees@lists.linuxfoundation.org,
jfs-discussion@lists.sourceforge.net,
linux-kernel@vger.kernel.org,
syzbot+411debe54d318eaed386@syzkaller.appspotmail.com,
Sasha Levin <sashal@kernel.org>
Subject: Re: [PATCH] jfs: fix shift-out-of-bounds in dbJoin
Date: Mon, 29 Jan 2024 22:13:19 +0000 [thread overview]
Message-ID: <Zbgi_3MyT0rL7oZs@casper.infradead.org> (raw)
In-Reply-To: <37af8f84-98bc-4733-bd9c-102b62fdd028@oracle.com>
On Mon, Jan 29, 2024 at 03:17:27PM -0600, Dave Kleikamp wrote:
> On 1/29/24 12:29PM, Matthew Wilcox wrote:
> > On Mon, Jan 29, 2024 at 09:00:56AM -0600, Dave Kleikamp wrote:
> > > On 1/29/24 8:55AM, Matthew Wilcox wrote:
> > > > On Mon, Jan 29, 2024 at 08:39:18AM -0600, Dave Kleikamp wrote:
> > > > > On 1/28/24 2:49PM, Matthew Wilcox wrote:
> > > > > > On Wed, Oct 11, 2023 at 08:09:37PM +0530, Manas Ghandat wrote:
> > > > > > > Currently while joining the leaf in a buddy system there is shift out
> > > > > > > of bound error in calculation of BUDSIZE. Added the required check
> > > > > > > to the BUDSIZE and fixed the documentation as well.
> > > > > >
> > > > > > This patch causes xfstests to fail frequently. The one this trace is
> > > > > > from was generic/074.
> > > > >
> > > > > Thanks for catching this. The sanity test is not right, so we need to revert
> > > > > that one.
> > > >
> > > > Unfortunately, my overnight test run with this patch reverted crashed
> > > > again with the same signature. I also reverted the parent commit,
> > > > and when that crashed I also reverted the parent of that. Which also
> > > > crashed.
> > > >
> > > > So maybe there's something else that makes this unstable. Or maybe my
> > > > bisect went wrong. Or _something_. Anyway, I'm going to spend much of
> > > > today hammering on generic/074 with various kernel versions and see what
> > > > I can deduce.
> > > >
> > > > So far I see no evidence that v6.7 crashes with g/074. And I know that
> > > > next-20240125 does crash with g/074. I'm pretty sure that v6.8-rc1 also
> > > > crashes with g/074, but will confirm that.
> > >
> > > I'll try to beat on it too and see what I find.
> > >
> > > Sasha, maybe hold up on to all the jfs patches for the time being.
> >
> > I have it reproducing easily on cca974daeb6c. I ran it a lot on
> > e0e1958f4c36 and have not reproduced it. So I'm going back to my
> > earlier assertion that cca974daeb6c is bad. Now, maybe other commits
> > are also bad?
>
> I was able to reproduce it too, but not after reverting that one. I believe
> it is the only one causing problems.
>
> I only asked Sasha to hold the other ones as a precaution until we were more
> confident that this one was the problem.
I can't reproduce any problem with v6.8-rc1 + this one reverted.
So I'm not sure what my overnight soak test found. I'll try a few other
things ...
prev parent reply other threads:[~2024-01-29 22:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-11 14:39 [PATCH] jfs: fix shift-out-of-bounds in dbJoin Manas Ghandat
2023-10-16 15:00 ` Manas Ghandat
2023-11-01 6:42 ` Manas Ghandat
2023-11-01 15:57 ` Dave Kleikamp
2024-01-28 20:49 ` Matthew Wilcox
2024-01-29 14:39 ` Dave Kleikamp
2024-01-29 14:55 ` Matthew Wilcox
2024-01-29 15:00 ` Dave Kleikamp
2024-01-29 18:29 ` Matthew Wilcox
2024-01-29 21:17 ` Dave Kleikamp
2024-01-29 22:13 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zbgi_3MyT0rL7oZs@casper.infradead.org \
--to=willy@infradead.org \
--cc=Linux-kernel-mentees@lists.linuxfoundation.org \
--cc=dave.kleikamp@oracle.com \
--cc=ghandatmanas@gmail.com \
--cc=jfs-discussion@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=sashal@kernel.org \
--cc=syzbot+411debe54d318eaed386@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).