From: Jiri Pirko <jiri@resnulli.us>
To: swarup <swarupkotikalapudi@gmail.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH net-next v3] netlink: specs: devlink: add some(not all) missing attributes in devlink.yaml
Date: Thu, 23 Nov 2023 19:15:20 +0100 [thread overview]
Message-ID: <ZV+WuPT9f5pDiHft@nanopsycho> (raw)
In-Reply-To: <ZV+UDY0B8AEkdVxc@swarup-virtual-machine>
Thu, Nov 23, 2023 at 07:03:57PM CET, swarupkotikalapudi@gmail.com wrote:
>On Thu, Nov 23, 2023 at 01:59:16PM +0100, Jiri Pirko wrote:
>> Thu, Nov 23, 2023 at 01:29:18PM CET, swarupkotikalapudi@gmail.com wrote:
>> >On Thu, Nov 23, 2023 at 11:12:15AM +0100, Jiri Pirko wrote:
>> >> Thu, Nov 23, 2023 at 11:01:19AM CET, swarupkotikalapudi@gmail.com wrote:
>> >> >Add some missing(not all) attributes in devlink.yaml.
>> >> >
>> >> >Re-generate the related devlink-user.[ch] code.
>> >> >
>> >> >enum have been given name as devlink_stats(for trap stats)
>> >> >and devlink_trap_metadata_type(for trap metadata type)
>> >> >
>> >> >Test result with trap-get command:
>> >> > $ sudo ./tools/net/ynl/cli.py \
>> >> > --spec Documentation/netlink/specs/devlink.yaml \
>> >> > --do trap-get --json '{"bus-name": "netdevsim", \
>> >> > "dev-name": "netdevsim1", \
>> >> > "trap-name": "ttl_value_is_too_small"}' --process-unknown
>> >> > {'attr-stats': {'rx-bytes': 47918326, 'rx-dropped': 21,
>> >> > 'rx-packets': 337453},
>> >> > 'bus-name': 'netdevsim',
>> >> > 'dev-name': 'netdevsim1',
>> >> > 'trap-action': 'trap',
>> >> > 'trap-generic': True,
>> >> > 'trap-group-name': 'l3_exceptions',
>> >> > 'trap-metadata': {'metadata-type-in-port': True},
>> >> > 'trap-name': 'ttl_value_is_too_small',
>> >> > 'trap-type': 'exception'}
>> >>
>> >> 1. You have to maintain 24 hours between submission of one
>> >> patch/patchset:
>> >> https://www.kernel.org/doc/html/v6.6/process/maintainer-netdev.html
>> >> 2. You didn't address my comment to last version
>> >>
>> >Hi Jiri,
>> >
>> >I have read the above link, but missed the constraint
>> >of 24 hour gap between patches.
>> >I will be careful and not send the patch again within 24 hours.
>> >
>> >I could not understand your 2nd point.
>> >Does it mean i should not include
>> >test result e.g. "Test result with trap-get command: ...."
>>
>> Does not make sense to me. If you put it like this, it implicates that
>> the trap attributes are the ones you are introducing in this patch.
>> However, you introduce much more.
>>
>>
>> >Or
>> >If it is something else, please elabroate more, which helps me to address your comment.
>> >
>> >I will try to clarify review comment, henceforth before sending new patchset for review.
>> >
>> >Thanks,
>> >Swarup
>
>Hi Jiri,
>
>I will submit a patch which has only trap attribute only changed.
>
>Thanks for the clarification.
Better to just remove the "test result" from the description.
>
>Thanks,
>Swarup
prev parent reply other threads:[~2023-11-23 18:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-23 10:01 [PATCH net-next v3] netlink: specs: devlink: add some(not all) missing attributes in devlink.yaml Swarup Laxman Kotiaklapudi
2023-11-23 10:12 ` Jiri Pirko
2023-11-23 12:29 ` swarup
2023-11-23 12:59 ` Jiri Pirko
2023-11-23 18:03 ` swarup
2023-11-23 18:15 ` Jiri Pirko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZV+WuPT9f5pDiHft@nanopsycho \
--to=jiri@resnulli.us \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=swarupkotikalapudi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).