From: Stanislav Fomichev <sdf@google.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Dipendra Khadka <kdipendra88@gmail.com>,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org,
syzbot+44c2416196b7c607f226@syzkaller.appspotmail.com,
Stanislav Fomichev <sdf@fomichev.me>
Subject: Re: [PATCH v2] Fixes the null pointer deferences in nsim_bpf
Date: Fri, 10 Nov 2023 11:20:36 -0800 [thread overview]
Message-ID: <ZU6ChFruBvEnA0V0@google.com> (raw)
In-Reply-To: <20231110111223.692adbd7@kernel.org>
On 11/10, Jakub Kicinski wrote:
> On Fri, 10 Nov 2023 11:18:23 +0000 Dipendra Khadka wrote:
> > Syzkaller found a null pointer dereference in nsim_bpf
> > originating from the lack of a null check for state.
> >
> > This patch fixes the issue by adding a check for state
> > in two functions nsim_prog_set_loaded() and nsim_setup_prog_hw_checks()
> >
> > Reported-by: syzbot+44c2416196b7c607f226@syzkaller.appspotmail.com
> > Closes: https://syzkaller.appspot.com./bug?extid=44c2416196b7c607f226
> > Fixes: 31d3ad832948 ("netdevsim: add bpf offload support")
>
> Don't think so. It's probably due to Stan's extensions / reuse of
> the offload infra.
>
> Please put more effort into figuring out when and why this started
> happening. Describe your findings in the commit message.
>
> Current patch looks too much like a bandaid.
>
> Before you repost read:
> https://www.kernel.org/doc/html/next/process/maintainer-netdev.html
I agree, I have a similar suspicion for the same report on the bpf list [0].
0: https://lore.kernel.org/bpf/ZU13dQb2z66CJlYi@google.com/
prev parent reply other threads:[~2023-11-10 19:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-10 8:44 [PATCH] Fixes the null pointer deferences in nsim_bpf Dipendra Khadka
2023-11-10 8:52 ` Eric Dumazet
2023-11-10 11:18 ` [PATCH v2] " Dipendra Khadka
2023-11-10 19:12 ` Jakub Kicinski
2023-11-10 19:20 ` Stanislav Fomichev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZU6ChFruBvEnA0V0@google.com \
--to=sdf@google.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kdipendra88@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=syzbot+44c2416196b7c607f226@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).