[PATCH] Bluetooth: hci_conn_failed: Fixes memory leak

From: Yuran Pereira <yuran.pereira@hotmail.com>
To: marcel@holtmann.org
Cc: johan.hedberg@gmail.com, linux-kernel@vger.kernel.org,
	linux-bluetooth@vger.kernel.org, luiz.dentz@gmail.com,
	syzbot+39ec16ff6cc18b1d066d@syzkaller.appspotmail.com,
	Yuran Pereira <yuran.pereira@hotmail.com>,
	linux-kernel-mentees@lists.linuxfoundation.org
Subject: [PATCH] Bluetooth: hci_conn_failed: Fixes memory leak
Date: Sat,  7 Oct 2023 17:09:01 +0530	[thread overview]
Message-ID: <AM9P192MB12672AA34A0480B522D23741E8C8A@AM9P192MB1267.EURP192.PROD.OUTLOOK.COM> (raw)

The hci_conn_failed() function currently calls hci_connect_cfm(), which
indirectly leads to the allocation of an l2cap_conn struct in l2cap_conn_add().
This operation results in a memory leak, as the l2cap_conn structure
becomes unreferenced.

To address this issue and prevent the memory leak, this patch modifies
hci_conn_failed() to replace the call to hci_connect_cfm() with a
call to hci_disconn_cfm().

Reported-by: syzbot+39ec16ff6cc18b1d066d@syzkaller.appspotmail.com
Signed-off-by: Yuran Pereira <yuran.pereira@hotmail.com>
---
 net/bluetooth/hci_conn.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/bluetooth/hci_conn.c b/net/bluetooth/hci_conn.c
index 7a6f20338db8..1d2d03b4a98a 100644
--- a/net/bluetooth/hci_conn.c
+++ b/net/bluetooth/hci_conn.c
@@ -1248,7 +1248,7 @@ void hci_conn_failed(struct hci_conn *conn, u8 status)
 	}
 
 	conn->state = BT_CLOSED;
-	hci_connect_cfm(conn, status);
+	hci_disconn_cfm(conn, status);
 	hci_conn_del(conn);
 }
 
-- 
2.25.1

_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
