From: Hans de Goede <hdegoede@redhat.com>
To: Dipendra Khadka <kdipendra88@gmail.com>,
mchehab@kernel.org, sakari.ailus@linux.intel.com,
gregkh@linuxfoundation.org, hpa@redhat.com
Cc: linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH] staging: media/atomisp/pci/runtime/rmgr/src: Fix spelling mistakes in rmgr_vbuf.c
Date: Sun, 31 Dec 2023 10:49:58 +0100 [thread overview]
Message-ID: <8cfc7753-37f6-48be-b7ae-dc28022989ae@redhat.com> (raw)
In-Reply-To: <20231223072245.81630-1-kdipendra88@gmail.com>
Hi,
On 12/23/23 08:22, Dipendra Khadka wrote:
> codespell reported following spelling mistake
> in rmgr_vbuf.cas below:
>
> '''
> ./runtime/rmgr/src/rmgr_vbuf.c:201: succes ==> success
> ./runtime/rmgr/src/rmgr_vbuf.c:211: succes ==> success
> ./runtime/rmgr/src/rmgr_vbuf.c:215: succes ==> success
> '''
> This patch fixes these spelling mistakes.
> It is good to use variable name that gives
> proper meaning and spelling error free.
>
> Signed-off-by: Dipendra Khadka <kdipendra88@gmail.com>
Thank you for your patch.
I have merged this in my media-atomisp branch:
https://git.kernel.org/pub/scm/linux/kernel/git/hansg/linux.git/log/?h=media-atomisp
And this patch will be included in my next
pull-request to Mauro (to media subsystem maintainer)
Regards,
Hans
> ---
> .../staging/media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c b/drivers/staging/media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c
> index 2e07dab8bf51..1f24db77fe38 100644
> --- a/drivers/staging/media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c
> +++ b/drivers/staging/media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c
> @@ -198,7 +198,7 @@ void rmgr_push_handle(struct ia_css_rmgr_vbuf_pool *pool,
> struct ia_css_rmgr_vbuf_handle **handle)
> {
> u32 i;
> - bool succes = false;
> + bool success = false;
>
> assert(pool);
> assert(pool->recycle);
> @@ -208,11 +208,11 @@ void rmgr_push_handle(struct ia_css_rmgr_vbuf_pool *pool,
> if (!pool->handles[i]) {
> ia_css_rmgr_refcount_retain_vbuf(handle);
> pool->handles[i] = *handle;
> - succes = true;
> + success = true;
> break;
> }
> }
> - assert(succes);
> + assert(success);
> }
>
> /*
prev parent reply other threads:[~2023-12-31 9:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-23 7:22 [PATCH] staging: media/atomisp/pci/runtime/rmgr/src: Fix spelling mistakes in rmgr_vbuf.c Dipendra Khadka
2023-12-31 9:49 ` Hans de Goede [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8cfc7753-37f6-48be-b7ae-dc28022989ae@redhat.com \
--to=hdegoede@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@redhat.com \
--cc=kdipendra88@gmail.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).