From: Shuah Khan <skhan@linuxfoundation.org>
To: angquan yu <angquan21@gmail.com>
Cc: shuah@kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] selftests/breakpoints: Fix format specifier in ksft_print_msg in step_after_suspend_test.c
Date: Thu, 30 Nov 2023 14:34:56 -0700 [thread overview]
Message-ID: <57c7feb8-9529-460d-af4e-db4591177f9f@linuxfoundation.org> (raw)
In-Reply-To: <20231128214854.60362-1-angquan21@gmail.com>
On 11/28/23 14:48, angquan yu wrote:
> From: angquan yu <angquan21@gmail.com>
>
> In the function 'tools/testing/selftests/breakpoints/run_test' within
> step_after_suspend_test.c, the ksft_print_msg function call incorrectly
> used '$s' as a format specifier. This commit corrects this typo to use the
> proper '%s' format specifier, ensuring the error message from
> waitpid() is correctly displayed.
>
> The issue manifested as a compilation warning (too many arguments
> for format [-Wformat-extra-args]), potentially obscuring actual
> runtime errors and complicating debugging processes.
>
> This fix enhances the clarity of error messages during test failures
> and ensures compliance with standard C format string conventions.
>
> Signed-off-by: angquan yu <angquan21@gmail.com>
Thank you for the fix. Applied to linux-kselftest next for Linux 6.8-rc1
thanks,
-- Shuah
prev parent reply other threads:[~2023-11-30 21:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-28 21:48 [PATCH] selftests/breakpoints: Fix format specifier in ksft_print_msg in step_after_suspend_test.c angquan yu
2023-11-30 21:34 ` Shuah Khan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57c7feb8-9529-460d-af4e-db4591177f9f@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=angquan21@gmail.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).