From: Shuah Khan <skhan@linuxfoundation.org>
To: Dorine Tipo <dorine.a.tipo@gmail.com>,
mic@digikod.net, outreachy@lists.linux.dev
Cc: "Fabio M . De Francesco"
<fabio.maria.de.francesco@linux.intel.com>,
Shuah Khan <skhan@linuxfoundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"linux-kernel-mentees@lists.linuxfoundation.org"
<linux-kernel-mentees@lists.linuxfoundation.org>
Subject: Re: [PATCH v2] Add Landlock test for io_uring IORING_OP_OPENAT operation
Date: Wed, 27 Mar 2024 10:12:58 -0600 [thread overview]
Message-ID: <3c8bcd55-3acd-4659-ab4d-567053049a7a@linuxfoundation.org> (raw)
In-Reply-To: <20240327132001.30576-1-dorine.a.tipo@gmail.com>
On 3/27/24 07:20, Dorine Tipo wrote:
> This patch expands Landlock test coverage to include io_uring operations.
> It introduces a test for IORING_OP_OPENAT with Landlock rules, verifying
> allowed and disallowed access. This mitigates potential security
> vulnerabilities by ensuring Landlock controls access through io_uring.
>
> It also updates the Makefile to include -luring in the LDLIBS.
> This ensures the test code has access to the necessary liburing
> library for io_uring operations.
>
> Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>
You are missing linux-kselftest and linux-kernel mailing lists
when you send kselftest patches.
cc linux-kernel-metees since you are a LFX mentee
Adding missing lists
> ---
> Changes since V1:
> V2: - Consolidated two dependent patches in the V1 series into one patch
> as suggested by <fabio.maria.de.francesco@linux.intel.com>
> - Updated the subject line to be more descriptive.
>
> tools/testing/selftests/landlock/Makefile | 4 +-
> tools/testing/selftests/landlock/fs_test.c | 132 +++++++++++++++++++++
> 2 files changed, 134 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/landlock/Makefile b/tools/testing/selftests/landlock/Makefile
> index 348e2dbdb4e0..ab47d1dadb62 100644
> --- a/tools/testing/selftests/landlock/Makefile
> +++ b/tools/testing/selftests/landlock/Makefile
> @@ -13,11 +13,11 @@ TEST_GEN_PROGS := $(src_test:.c=)
> TEST_GEN_PROGS_EXTENDED := true
>
> # Short targets:
> -$(TEST_GEN_PROGS): LDLIBS += -lcap
> +$(TEST_GEN_PROGS): LDLIBS += -lcap -luring
Check if .gitignore needs updates since you are adding
a new executable.
The rest look good to me.
Acked-by: Shuah Khan <skhan@linuxfoundation.org>
thanks,
-- Shuah
parent reply other threads:[~2024-03-27 16:13 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20240327132001.30576-1-dorine.a.tipo@gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c8bcd55-3acd-4659-ab4d-567053049a7a@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=dorine.a.tipo@gmail.com \
--cc=fabio.maria.de.francesco@linux.intel.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mic@digikod.net \
--cc=outreachy@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).