From: Borislav Petkov <bp@alien8.de>
To: Abhinav Singh <singhabhinav9051571833@gmail.com>
Cc: tony.luck@intel.com, qiuxu.zhuo@intel.com, james.morse@arm.com,
mchehab@kernel.org, rric@kernel.org, linux-edac@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH] driver : edac : Fix warning using plain integer as NULL
Date: Mon, 27 Nov 2023 21:29:06 +0100 [thread overview]
Message-ID: <20231127202906.GIZWT8EgKxGzLQTRtw@fat_crate.local> (raw)
In-Reply-To: <af489962-705f-4a72-943d-ba3b46d64597@gmail.com>
On Tue, Nov 28, 2023 at 01:49:06AM +0530, Abhinav Singh wrote:a
> Okay, so I guess as of now there is no change needed, so I need not
> send a v2 patch, right?
As of now, you should go back and reread the whole thread.
I'm going to give you one last example and then stop:
Imagine one fine day you're doing git archeology, you find the place in
the code about which you want to find out why it was changed the way it
is now.
You do git annotate <filename> ... find the line, see the commit id and
you do:
git show <commit id>
You read the commit message and there's just gibberish and nothing's
explaining *why* that change was done. And you start scratching your
head, trying to figure out why. Because the damn commit message is worth
sh*t.
This happens to us maintainers at least once a week. Well, I don't want
that to happen in my tree anymore.
You catch my drift? :)
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2023-11-27 20:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-09 21:21 [PATCH] driver : edac : Fix warning using plain integer as NULL Abhinav Singh
2023-11-25 19:37 ` Abhinav Singh
2023-11-27 17:14 ` Borislav Petkov
2023-11-27 18:23 ` Abhinav Singh
2023-11-27 18:39 ` Borislav Petkov
2023-11-27 18:53 ` Abhinav Singh
2023-11-27 20:05 ` Borislav Petkov
2023-11-27 20:19 ` Abhinav Singh
2023-11-27 20:29 ` Borislav Petkov [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-11-09 21:20 [PATCH] driver : edac " Abhinav Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231127202906.GIZWT8EgKxGzLQTRtw@fat_crate.local \
--to=bp@alien8.de \
--cc=james.morse@arm.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=qiuxu.zhuo@intel.com \
--cc=rric@kernel.org \
--cc=singhabhinav9051571833@gmail.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).