From: Jakub Kicinski <kuba@kernel.org>
To: Swarup Laxman Kotiaklapudi <swarupkotikalapudi@gmail.com>
Cc: davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
jiri@resnulli.us, netdev@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH net-next v4] netlink: specs: devlink: add some(not all) missing attributes in devlink.yaml
Date: Mon, 27 Nov 2023 13:16:41 -0800 [thread overview]
Message-ID: <20231127131641.320e2a27@kernel.org> (raw)
In-Reply-To: <20231126105246.195288-1-swarupkotikalapudi@gmail.com>
On Sun, 26 Nov 2023 16:22:46 +0530 Swarup Laxman Kotiaklapudi wrote:
> diff --git a/include/uapi/linux/devlink.h b/include/uapi/linux/devlink.h
> index b3c8383d342d..ddb689dd3d7e 100644
> --- a/include/uapi/linux/devlink.h
> +++ b/include/uapi/linux/devlink.h
> @@ -248,7 +248,7 @@ enum devlink_param_reset_dev_on_drv_probe_value {
> DEVLINK_PARAM_RESET_DEV_ON_DRV_PROBE_VALUE_DISK,
> };
>
> -enum {
> +enum devlink_stats {
> DEVLINK_ATTR_STATS_RX_PACKETS, /* u64 */
> DEVLINK_ATTR_STATS_RX_BYTES, /* u64 */
> DEVLINK_ATTR_STATS_RX_DROPPED, /* u64 */
This change unfortunately breaks the kernel build. There's already
a struct called devlink_stats. You can change that later but that'd
be a separate patch, after the spec changes are accepted.
For now just keep these enums unnamed.
If the C codegen tries to use them as named (which I don't see it doing
now, FWIW) you can add an empty enum-name: attribute to the appropriate
enum definition in the spec, this will make the C code generator use a
bare "int" to store the values.
--
pw-bot: cr
prev parent reply other threads:[~2023-11-27 21:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-26 10:52 [PATCH net-next v4] netlink: specs: devlink: add some(not all) missing attributes in devlink.yaml Swarup Laxman Kotiaklapudi
2023-11-27 21:16 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231127131641.320e2a27@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jiri@resnulli.us \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=swarupkotikalapudi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).