From: Conor Dooley <conor@kernel.org>
To: Anshul Dalal <anshulusr@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, Conor Dooley <conor+dt@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-kernel-mentees@lists.linuxfoundation.org,
Jonathan Cameron <jic23@kernel.org>
Subject: Re: [PATCH v2 2/3] dt-bindings: trivial-devices: add aosong,ags02ma
Date: Wed, 15 Nov 2023 19:40:31 +0000 [thread overview]
Message-ID: <20231115-humble-sleek-e401e01de5dd@squawk> (raw)
In-Reply-To: <9b1674d7-c41d-4d8b-bb28-09ed201c72cd@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 3300 bytes --]
On Wed, Nov 15, 2023 at 09:29:20PM +0530, Anshul Dalal wrote:
> On 11/15/23 20:08, Conor Dooley wrote:
> > On Wed, Nov 15, 2023 at 06:28:07PM +0530, Anshul Dalal wrote:
> >> Add bindings for Aosong AGS02MA TVOC sensor.
> >>
> >> The sensor communicates over i2c with the default address 0x1a.
> >> TVOC values can be read in the units of ppb and ug/m^3 at register 0x00.
> >>
> >> Datasheet:
> >> https://asairsensors.com/wp-content/uploads/2021/09/AGS02MA.pdf
> >> Product-Page:
> >> http://www.aosong.com/m/en/products-33.html
> >>
> >> Signed-off-by: Anshul Dalal <anshulusr@gmail.com>
> >> ---
> >>
> >> Changes for v2:
> >> - Removed device from trivial-devices
> >
> > Your $subject still says "trivial-devices" though, so please fix that in
> > your next submission.
> >
> >> - Added standalone binding with vdd-supply property
> >> ---
> >> .../bindings/iio/chemical/aosong,ags02ma.yaml | 48 +++++++++++++++++++
> >> 1 file changed, 48 insertions(+)
> >> create mode 100644 Documentation/devicetree/bindings/iio/chemical/aosong,ags02ma.yaml
> >>
> >> diff --git a/Documentation/devicetree/bindings/iio/chemical/aosong,ags02ma.yaml b/Documentation/devicetree/bindings/iio/chemical/aosong,ags02ma.yaml
> >> new file mode 100644
> >> index 000000000000..4a0278c6318c
> >> --- /dev/null
> >> +++ b/Documentation/devicetree/bindings/iio/chemical/aosong,ags02ma.yaml
> >> @@ -0,0 +1,48 @@
> >> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> >> +%YAML 1.2
> >> +---
> >> +$id: http://devicetree.org/schemas/iio/chemical/aosong,ags02ma.yaml#
> >> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> >> +
> >> +title: Aosong AGS02MA VOC Sensor
> >> +
> >> +description: |
> >> + AGS02MA is an TVOC (Total Volatile Organic Compounds) i2c sensor with default
> >> + address of 0x1a.
> >> +
> >> + Datasheet:
> >> + https://asairsensors.com/wp-content/uploads/2021/09/AGS02MA.pdf
> >> +
> >> +maintainers:
> >> + - Anshul Dalal <anshulusr@gmail.com>
> >> +
> >> +properties:
> >> + compatible:
> >> + enum:
> >> + - aosong,ags02ma
> >> + - asair,ags02ma
> >
> > Why do you have two compatibles for the same device? Please document and
> > use only one of these. The aoson website says:
> > "Guangzhou ASAIR Electronic Co., Ltd"
>
> I'm sorry but I couldn't find any reference to such name on
> http://www.aosong.com/en/
> In the contact page (http://www.aosong.com/en/article-34.html),
> I could only find references to "Guangzhou Aosong Electronic Co., Ltd."
On the page you linked in your original submission:
www.aosong.com/m/en/products-33.html
(scroll down)
> > so I suspect "asair" is a more apt vendor prefix.
> >
>
> Asair is the brand name under which Guangzhou Aosong Electronics sells
> their products [0]. After a prior discussion with Krzysztof [1], I
> thought it would be the best to go with Aosong instead.
>
> The rationale being since a vendor can only have a single prefix, if
> Aosong were to sell some new product under the name Aosong, it would
> then have to have the same vendor-prefix as other products under the
> Asair brand.
Go with Aosong then, sure. But please drop the "asair" prefixed
compatible from your binding.
Cheers,
Conor,
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-11-15 19:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-15 12:58 [PATCH v2 1/3] dt-bindings: vendor-prefixes: add aosong Anshul Dalal
2023-11-15 12:58 ` [PATCH v2 2/3] dt-bindings: trivial-devices: add aosong,ags02ma Anshul Dalal
2023-11-15 14:38 ` Conor Dooley
2023-11-15 15:59 ` Anshul Dalal
2023-11-15 19:40 ` Conor Dooley [this message]
2023-11-15 12:58 ` [PATCH v2 3/3] iio: chemical: add support for Aosong AGS02MA Anshul Dalal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231115-humble-sleek-e401e01de5dd@squawk \
--to=conor@kernel.org \
--cc=anshulusr@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).