From: Swarup Laxman Kotiaklapudi <swarupkotikalapudi@gmail.com>
To: corbet@lwn.net, yujie.liu@intel.com, linux-doc@vger.kernel.org,
swarupkotikalapudi@gmail.com,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: [PATCH] scripts/kernel-doc: fix make htmldoc warning
Date: Sat, 28 Oct 2023 23:52:31 +0530 [thread overview]
Message-ID: <20231028182231.123996-1-swarupkotikalapudi@gmail.com> (raw)
make htmldocs has below warnings:
..
Variable length lookbehind is experimental in regex;
marked by <-- HERE in m/(?<=^|\s)-Werror(?=$|\s)
<-- HERE / at ./scripts/kernel-doc line 188.
...
"-Werror" option in make command,
needs "-Werror" to have space before
and after while running make command,
hence space checking is sepratly done,
and is not part of lookbehind regular expression.
Below command also didn't
show any error:
make KCFLAGS="-Werror=return-type" W=1 kernel/fork.o
Fixes: 91f950e8b9d8 ("scripts/kernel-doc: match -Werror flag strictly")
Signed-off-by: Swarup Laxman Kotiaklapudi <swarupkotikalapudi@gmail.com>
---
scripts/kernel-doc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/kernel-doc b/scripts/kernel-doc
index d660e1f4b483..aa9e3e198d12 100755
--- a/scripts/kernel-doc
+++ b/scripts/kernel-doc
@@ -185,7 +185,7 @@ if (defined($ENV{'KBUILD_VERBOSE'}) && $ENV{'KBUILD_VERBOSE'} =~ '1') {
if (defined($ENV{'KCFLAGS'})) {
my $kcflags = "$ENV{'KCFLAGS'}";
- if ($kcflags =~ /(?<=^|\s)-Werror(?=$|\s)/) {
+ if ($kcflags =~ /(?<=^|)(\s)-Werror(?=$|)(\s)/) {
$Werror = 1;
}
}
--
2.34.1
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next reply other threads:[~2023-10-28 18:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-28 18:22 Swarup Laxman Kotiaklapudi [this message]
2023-10-29 18:06 ` [PATCH] scripts/kernel-doc: fix make htmldoc warning Jonathan Corbet
2023-10-30 0:02 ` Akira Yokosawa
2023-10-30 5:37 ` Yujie Liu
2023-10-30 9:18 ` Yujie Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231028182231.123996-1-swarupkotikalapudi@gmail.com \
--to=swarupkotikalapudi@gmail.com \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=yujie.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).