From: Aurabindo Pillai via Linux-kernel-mentees <linux-kernel-mentees@lists.linuxfoundation.org>
To: "José Pekkarinen" <jose.pekkarinen@foxhound.fi>
Cc: dillon.varone@amd.com, george.shen@amd.com, sunpeng.li@amd.com,
airlied@gmail.com, dri-devel@lists.freedesktop.org,
Xinhui.Pan@amd.com, Rodrigo.Siqueira@amd.com,
linux-kernel@vger.kernel.org, samson.tam@amd.com,
SyedSaaem.Rizvi@amd.com, amd-gfx@lists.freedesktop.org,
daniel@ffwll.ch, alexander.deucher@amd.com, Jun.Lei@amd.com,
harry.wentland@amd.com, christian.koenig@amd.com,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH] drm/amd/display: remove redundant check
Date: Mon, 30 Oct 2023 12:53:58 -0400 [thread overview]
Message-ID: <1ce5a7ae-b38e-433b-8f73-4bfc95bfe9c3@amd.com> (raw)
In-Reply-To: <3c228e4f69c01dddd4743bdb68845566@foxhound.fi>
On 2023-10-30 12:26, José Pekkarinen wrote:
> On 2023-10-30 15:52, Aurabindo Pillai wrote:
>> On 10/29/2023 8:44 AM, José Pekkarinen wrote:
>>> This patch addresses the following warning spotted by
>>> using coccinelle where the case checked does the same
>>> than the else case.
>>>
>>> drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c:4664:8-10: WARNING: possible condition with no effect (if == else)
>>>
>>> Signed-off-by: José Pekkarinen <jose.pekkarinen@foxhound.fi>
>>> ---
>>> .../drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c | 4 ----
>>> 1 file changed, 4 deletions(-)
>>>
>>> diff --git
>>> a/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c
>>> b/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c
>>> index ecea008f19d3..d940dfa5ae43 100644
>>> ---
>>> a/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c
>>> +++
>>> b/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c
>>> @@ -4661,10 +4661,6 @@ void dml32_CalculateMinAndMaxPrefetchMode(
>>> } else if (AllowForPStateChangeOrStutterInVBlankFinal ==
>>> dm_prefetch_support_uclk_fclk_and_stutter) {
>>> *MinPrefetchMode = 0;
>>> *MaxPrefetchMode = 0;
>>> - } else if (AllowForPStateChangeOrStutterInVBlankFinal ==
>>> - dm_prefetch_support_uclk_fclk_and_stutter_if_possible) {
>>> - *MinPrefetchMode = 0;
>>> - *MaxPrefetchMode = 3;
>>> } else {
>>> *MinPrefetchMode = 0;
>>> *MaxPrefetchMode = 3;
>>
>> What tree did you use to generate the patch? On amd-staging-drm-next,
>> MaxPrefetchMode is 0 for the second last branch, which is the correct
>> one, so this patch isnt needed.
>
> I'm using the stable tree, sorry, if it is out of
> date just ignore it then.
>
> Thanks!
>
> José.
Actually, you're right - the patch's limited context mislead me, sorry.
But please add the following tag and sent it to stable@vger.kernel.org
instead:
Fixes: 974ce181 ("drm/amd/display: Add check for PState change in DCN32")
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2023-10-30 16:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-29 12:44 [PATCH] drm/amd/display: remove redundant check José Pekkarinen
2023-10-30 13:52 ` Aurabindo Pillai via Linux-kernel-mentees
2023-10-30 16:26 ` José Pekkarinen
2023-10-30 16:53 ` Aurabindo Pillai via Linux-kernel-mentees [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-10-30 17:04 José Pekkarinen
2023-10-30 17:17 José Pekkarinen
2023-10-30 17:39 ` Aurabindo Pillai via Linux-kernel-mentees
2023-10-31 5:48 ` Greg KH
2023-10-31 11:42 ` José Pekkarinen
2023-10-31 12:20 ` Greg KH
2023-10-31 12:32 ` José Pekkarinen
2023-10-31 16:41 ` Aurabindo Pillai via Linux-kernel-mentees
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ce5a7ae-b38e-433b-8f73-4bfc95bfe9c3@amd.com \
--to=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=Jun.Lei@amd.com \
--cc=Rodrigo.Siqueira@amd.com \
--cc=SyedSaaem.Rizvi@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=aurabindo.pillai@amd.com \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dillon.varone@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=george.shen@amd.com \
--cc=harry.wentland@amd.com \
--cc=jose.pekkarinen@foxhound.fi \
--cc=linux-kernel@vger.kernel.org \
--cc=samson.tam@amd.com \
--cc=sunpeng.li@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).