From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Andrew Morton <akpm@linux-foundation.org>,
Nicolas Schier <nicolas@fjasle.eu>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
linux-kbuild@vger.kernel.org
Subject: Re: linux-next: build warning after merge of the mm tree
Date: Wed, 13 Mar 2024 22:11:38 +0100 [thread overview]
Message-ID: <gegwogwbrigfaqjoymgndji6wmllqgkhs2mmgvpksqzsil64zr@pimmxvvvgbqz> (raw)
In-Reply-To: <CAK7LNASa-KedA_CTww6unckAGkJCQTctdbk0d-MUsN7wQpM=kQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2315 bytes --]
Hello Masahiro,
On Thu, Mar 14, 2024 at 12:22:46AM +0900, Masahiro Yamada wrote:
> On Wed, Mar 13, 2024 at 6:01 PM Uwe Kleine-König
> <u.kleine-koenig@pengutronix.de> wrote:
> >
> > On Wed, Mar 13, 2024 at 03:07:28PM +1100, Stephen Rothwell wrote:
> > > Hi all,
> > >
> > > After merging the mm tree, today's linux-next build (powerpc allyesconfig)
> > > produced this warning:
> > >
> > > Use of uninitialized value $ENV{"abs_srctree"} in concatenation (.) or string at /home/sfr/next/next/lib/build_OID_registry line 38.
> > >
> > > Introduced by commit
> > >
> > > 325f7b0aaea6 ("lib/build_OID_registry: Don't mention the full path of the script in output")
> > >
> > > from the mm-nonmm-unstable branch of the mm tree.
> >
> > Actually the warning doesn't happen on 325f7b0aaea6. The commit is only
> > problematic in combination with commit
> >
> > e2bad142bb3d ("kbuild: unexport abs_srctree and abs_objtree")
> >
> > . This commit suggests to use $(abspath ) or $(realpath ) instead, but I
> > fail to apply this suggestion here.
> >
> > Obviously
> >
> > diff --git a/Makefile b/Makefile
> > index 5e09b53b4850..f73a73a125e0 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -39,7 +39,7 @@ __all:
> > # prepare rule.
> >
> > this-makefile := $(lastword $(MAKEFILE_LIST))
> > -abs_srctree := $(realpath $(dir $(this-makefile)))
> > +export abs_srctree := $(realpath $(dir $(this-makefile)))
> > abs_objtree := $(CURDIR)
> >
> > ifneq ($(sub_make_done),1)
> >
> > would help.
> >
> > Any ideas how to properly handle that? Would the export be ok?
>
> Oh well, you are making a lot of effort just for a C comment line.
I don't care much either. Given that now I know how to somewhat keep the
originally intended information, the effort between a fixed string and
a dynamically generated one isn't very relevant.
> use Cwd qw(abs_path);
>
> my $abs_srctree = abs_path($ENV{'srctree'});
Ah, I missed that srctree is an exported variable. Thanks, will prepare
a v2. akpm already dropped my initial patch from his queue.
Thanks for your input.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2024-03-13 21:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240313150728.12e20208@canb.auug.org.au>
2024-03-13 9:00 ` linux-next: build warning after merge of the mm tree Uwe Kleine-König
2024-03-13 15:22 ` Masahiro Yamada
2024-03-13 21:11 ` Uwe Kleine-König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=gegwogwbrigfaqjoymgndji6wmllqgkhs2mmgvpksqzsil64zr@pimmxvvvgbqz \
--to=u.kleine-koenig@pengutronix.de \
--cc=akpm@linux-foundation.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=nicolas@fjasle.eu \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).