From: Jeff Johnson <quic_jjohnson@quicinc.com>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Kalle Valo <kvalo@kernel.org>, Jeff Johnson <jjohnson@kernel.org>,
Stephen Boyd <swboyd@chromium.org>,
Rakesh Pillai <quic_pillair@quicinc.com>,
<linux-wireless@vger.kernel.org>, <ath10k@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <stable@vger.kernel.org>,
<linux-kbuild@vger.kernel.org>
Subject: Re: [PATCH] wifi: ath10k: fix QCOM_RPROC_COMMON dependency
Date: Tue, 14 May 2024 11:14:49 -0700 [thread overview]
Message-ID: <e5edd92e-ab47-4a55-9276-5a7d160fd399@quicinc.com> (raw)
In-Reply-To: <CAK7LNASyBNbxm-e+iZ=7pOJg-a-Zm84O6RNcqiUjZQH7f9r3Lw@mail.gmail.com>
On 5/14/2024 10:45 AM, Masahiro Yamada wrote:
> On Tue, May 14, 2024 at 11:43 PM Jeff Johnson <quic_jjohnson@quicinc.com> wrote:
>>
>> On 5/11/2024 3:49 AM, Dmitry Baryshkov wrote:
>>> If ath10k_snoc is built-in, while Qualcomm remoteprocs are built as
>>> modules, compilation fails with:
>>>
>>> /usr/bin/aarch64-linux-gnu-ld: drivers/net/wireless/ath/ath10k/snoc.o: in function `ath10k_modem_init':
>>> drivers/net/wireless/ath/ath10k/snoc.c:1534: undefined reference to `qcom_register_ssr_notifier'
>>> /usr/bin/aarch64-linux-gnu-ld: drivers/net/wireless/ath/ath10k/snoc.o: in function `ath10k_modem_deinit':
>>> drivers/net/wireless/ath/ath10k/snoc.c:1551: undefined reference to `qcom_unregister_ssr_notifier'
>>>
>>> Add corresponding dependency to ATH10K_SNOC Kconfig entry so that it's
>>> built as module if QCOM_RPROC_COMMON is built as module too.
>>>
>>> Fixes: 747ff7d3d742 ("ath10k: Don't always treat modem stop events as crashes")
>>> Cc: stable@vger.kernel.org
>>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>>> ---
>>> drivers/net/wireless/ath/ath10k/Kconfig | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/net/wireless/ath/ath10k/Kconfig b/drivers/net/wireless/ath/ath10k/Kconfig
>>> index e6ea884cafc1..4f385f4a8cef 100644
>>> --- a/drivers/net/wireless/ath/ath10k/Kconfig
>>> +++ b/drivers/net/wireless/ath/ath10k/Kconfig
>>> @@ -45,6 +45,7 @@ config ATH10K_SNOC
>>> depends on ATH10K
>>> depends on ARCH_QCOM || COMPILE_TEST
>>> depends on QCOM_SMEM
>>> + depends on QCOM_RPROC_COMMON || QCOM_RPROC_COMMON=n
>>> select QCOM_SCM
>>> select QCOM_QMI_HELPERS
>>> help
>>>
>>> ---
>>> base-commit: 75fa778d74b786a1608d55d655d42b480a6fa8bd
>>> change-id: 20240511-ath10k-snoc-dep-862a9da2e6bb
>>
>> I see how this fixes the problem, but this doesn't seem like an ideal
>> solution. The fact that the *_ssr_notifier() functions are correctly protected
>> by conditional compilation ideally should mean that clients don't need to call
>> call out this as a dependency. Otherwise, it would mean we'd need to do this
>> for all feature flags.
>
>
> It depends on if qcom_common.c is optional for ath10k_snoc.
>
> If it is optional, this patch is correct.
At least from a build perspective it is optional
>
>
> If it is mandatory
> depends on QCOM_RPROC_COMMON
>
>
>>
>> +linux-kbuild just to make sure there isn't a better approach.
>
>
> Commit 28d49e171676afb7df7f47798391364af9abed7f suggested
>
> depends on BAR || !BAR
>
> but
>
> depends on BAR || BAR=n
>
> works equivalently.
Thanks for the information.
I'll let Kalle decide if he wants to change this in 'pending' to:
depends on QCOM_RPROC_COMMON || !QCOM_RPROC_COMMON
Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com>
next prev parent reply other threads:[~2024-05-14 18:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240511-ath10k-snoc-dep-v1-1-9666e3af5c27@linaro.org>
2024-05-14 14:43 ` [PATCH] wifi: ath10k: fix QCOM_RPROC_COMMON dependency Jeff Johnson
2024-05-14 17:45 ` Masahiro Yamada
2024-05-14 18:14 ` Jeff Johnson [this message]
2024-05-15 4:10 ` Masahiro Yamada
2024-05-15 22:43 ` Jeff Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5edd92e-ab47-4a55-9276-5a7d160fd399@quicinc.com \
--to=quic_jjohnson@quicinc.com \
--cc=ath10k@lists.infradead.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=jjohnson@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=quic_pillair@quicinc.com \
--cc=stable@vger.kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).