From: Herbert Xu <herbert@gondor.apana.org.au>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Olivia Mackall <olivia@selenic.com>,
linux-crypto@vger.kernel.org, kernel@pengutronix.de,
linux-kbuild@vger.kernel.org
Subject: Re: [PATCH v2] hwrng: mxc-rnga: Drop usage of platform_driver_probe()
Date: Thu, 28 Mar 2024 18:58:04 +0800 [thread overview]
Message-ID: <ZgVNPH0EuGAjz/9R@gondor.apana.org.au> (raw)
In-Reply-To: <20240324161227.239718-2-u.kleine-koenig@pengutronix.de>
On Sun, Mar 24, 2024 at 05:12:26PM +0100, Uwe Kleine-König wrote:
> There are considerations to drop platform_driver_probe() as a concept
> that isn't relevant any more today. It comes with an added complexity
> that makes many users hold it wrong. (E.g. this driver should have mark
> the driver struct with __refdata.)
>
> Convert the driver to the more usual module_platform_driver().
>
> This fixes a W=1 build warning:
>
> WARNING: modpost: drivers/char/hw_random/mxc-rnga: section mismatch in reference: mxc_rnga_driver+0x10 (section: .data) -> mxc_rnga_remove (section: .exit.text)
>
> with CONFIG_HW_RANDOM_MXC_RNGA=m.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> Hello,
>
> while I indeed fixed the mentioned warning in (implicit) v1, I
> introduced another one because I failed to drop __init from
> mxc_rnga_probe. :-\
>
> This is fixed here.
>
> Best regards
> Uwe
>
> drivers/char/hw_random/mxc-rnga.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2024-03-28 10:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-24 16:12 [PATCH v2] hwrng: mxc-rnga: Drop usage of platform_driver_probe() Uwe Kleine-König
2024-03-28 10:58 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZgVNPH0EuGAjz/9R@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=kernel@pengutronix.de \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=olivia@selenic.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).