From: Masahiro Yamada <masahiroy@kernel.org>
To: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>,
linux-sh@vger.kernel.org
Subject: Re: [PATCH 1/2] sh: convert the last use of 'optional' property in Kconfig
Date: Mon, 22 Apr 2024 11:27:34 +0900 [thread overview]
Message-ID: <CAK7LNASyu9=7MQ0zd8doGEENN7GHxupg+fkpK3FCktyjVwLfjw@mail.gmail.com> (raw)
In-Reply-To: <80d969b70038f5c0de6f2d912cb1f6b395eea94a.camel@physik.fu-berlin.de>
On Mon, Apr 22, 2024 at 2:51 AM John Paul Adrian Glaubitz
<glaubitz@physik.fu-berlin.de> wrote:
>
> Hi Masahiro,
>
> On Sun, 2024-04-21 at 21:08 +0900, Masahiro Yamada wrote:
> > The 'choice' statement is primarily used to exclusively select one
> > option, but the 'optional' property allows all entries to be disabled.
> >
> > This feature is only used in arch/sh/Kconfig because the equivalent
> > outcome can be achieved by inserting one more entry as a place-holder.
> > This approach is commonly used, for example, LTO_NONE, DEBUG_INFO_NONE,
> > INITRAMFS_COMPRESSION_NONE, etc.
> >
> > The 'optional' property support will be removed from Kconfig.
> >
> > This commit converts the last user.
> >
> > Note:
> > The 'default CMDLINE_OVERWRITE' statement does not work as intended
> > in combination with 'optional'. If neither CONFIG_CMDLINE_OVERWRITE
> > nor CONFIG_CMD_EXTEND is specified in a defconfig file, both of them
> > are disabled. This is a bug. To maintain the current behavior, I
> > added CONFIG_CMD_NO_MODIFY=y to those defconfig files.
> ^^^^^^^^^^^^^^^^^^^^^^
> This would be CMDLINE_NO_MODIFY as used in the actual Kconfig files.
>
> I am fine with the change per se, but could you rename CMDLINE_NO_MODIFY to
> CMDLINE_FROM_BOOTLOADER as it's used on the other architectures such as arm
> and powerpc, preferably using the same help text.
OK, but the sh behavior is different from
early_init_dt_scan_chosen().
I will drop this part:
"If the boot loader doesn't provide any, the default
kernel command string provided in CMDLINE will be used."
config CMDLINE_FROM_BOOTLOADER
bool "Use bootloader kernel arguments"
help
Uses the command-line options passed by the boot loader.
>
> Also, I usually prefer the first word in the subject to be capitalized, i.e..
>
> sh: Convert the last use of 'optional' property in Kconfig
>
> Thanks,
> Adrian
>
> --
> .''`. John Paul Adrian Glaubitz
> : :' : Debian Developer
> `. `' Physicist
> `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
>
--
Best Regards
Masahiro Yamada
next prev parent reply other threads:[~2024-04-22 2:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-21 12:08 [PATCH 0/2] kconfig: remove unneeded 'optional' property support Masahiro Yamada
2024-04-21 12:08 ` [PATCH 1/2] sh: convert the last use of 'optional' property in Kconfig Masahiro Yamada
2024-04-21 17:51 ` John Paul Adrian Glaubitz
2024-04-22 2:27 ` Masahiro Yamada [this message]
2024-04-21 12:08 ` [PATCH 2/2] kconfig: remove 'optional' property support Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK7LNASyu9=7MQ0zd8doGEENN7GHxupg+fkpK3FCktyjVwLfjw@mail.gmail.com' \
--to=masahiroy@kernel.org \
--cc=dalias@libc.org \
--cc=glaubitz@physik.fu-berlin.de \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).